Merge pull request #627 from internetarchive/improved-suggestion

Improved suggestions

Author: anishsarangi

bin/deploy-to-alexa-skill.sh

@@ -19,9 +19,23 @@ cp ./functions/index-alexa.js ./deploy/alexa/index-alexa.js
 cp ./functions/package.json ./deploy/alexa/package.json
 # aws-sdk is already available in AWS Lambda running the app, we delete it to
 # reduce the filesize because the unzipped code must be < 250MB
-# `npm install -g node-prune` is required
-(cd ./deploy/alexa/; npm install --production; rm -rf node_modules/aws-sdk; node-prune node_modules)
-# TODO show size of unzipped (it should be less then 250M)
+# `npm install -g node-prune` is required (optional but recommended)
+echo -e "$checkit  installing dependencies"
+(cd ./deploy/alexa/; npm install --omit=dev --legacy-peer-deps; rm -rf node_modules/aws-sdk)
+# Check if node-prune is available and use it if present
+if command -v node-prune &> /dev/null; then
+  echo -e "$checkit  pruning node_modules"
+  (cd ./deploy/alexa/; node-prune node_modules)
+else
+  echo -e "⚠️  node-prune not found (optional). Install with: npm install -g node-prune"
+fi
+# Check size of unzipped (should be less than 250MB)
+UNZIPPED_SIZE=$(du -sm ./deploy/alexa | cut -f1)
+echo -e "$checkit  unzipped size: ${UNZIPPED_SIZE}MB"
+if [ "$UNZIPPED_SIZE" -gt 250 ]; then
+  echo "⚠️  WARNING: Unzipped size (${UNZIPPED_SIZE}MB) exceeds 250MB AWS Lambda limit!"
+  echo "   Consider using node-prune or removing unnecessary dependencies"
+fi
 
 # zip files
 echo -e "$checkit  zip files"

functions/package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "audio-interface-of-internet-archive",
   "description": "Audio Interface of Internet Archive",
-  "version": "2.5.18",
+  "version": "2.5.19",
   "private": true,
   "author": "Internet Archive",
   "license": "AGPL-3.0",

functions/package.json

@@ -35,17 +35,28 @@ const mapSongDataToSlots = ({ type = 'current' } = {}) => (ctx) => {
     return Promise.reject(new EmptySongDataError(ctx, 'there is no song data'));
   }
 
+  // Preserve original coverage and year from user's selection if they exist,
+  // so the response matches what the user selected rather than what the album has
+  const originalCoverage = slots.coverage;
+  const originalYear = slots.year;
+
   // we need to escape song data because they could have special symbols
   // like < or > but we should do it only for speech because it uses SSML
   const slotsWithEscapedSongDetails = {
     ...slots,
     ...escapeHTMLObject(song, { skipFields: ['audioURL', 'imageURL'] }),
+    // Preserve user-selected coverage and year
+    ...(originalCoverage && { coverage: originalCoverage }),
+    ...(originalYear && { year: originalYear }),
   };
 
   // in all other cases we could have these special symbols
   const slotsWithOriginalSongDetails = {
     ...slots,
     ...song,
+    // Preserve user-selected coverage and year to ensure response matches user's selection
+    ...(originalCoverage && { coverage: originalCoverage }),
+    ...(originalYear && { year: originalYear }),
   };
 
   const playbackUIScheme = selectors.find(availableStrings, slotsWithOriginalSongDetails);