simplify params

Author: RayBB

openlibrary/fastapi/partials.py

@@ -64,10 +64,8 @@ async def partials_endpoint(
         return AffiliateLinksPartial(data=parsed_data).generate()
 
     elif _component == "BPListsSection":
-        # Use separate query parameters
-        return BookPageListsPartial(
-            data={"workId": workId, "editionId": editionId}
-        ).generate()
+        # Pass parameters directly - much simpler!
+        return BookPageListsPartial(workId=workId, editionId=editionId).generate()
 
     elif _component == "FulltextSearchSuggestion":
         # data is just a string, not JSON

openlibrary/plugins/openlibrary/partials.py

@@ -303,21 +303,19 @@ def generate(self) -> dict:
 class BookPageListsPartial(PartialDataHandler):
     """Handler for rendering the book page "Lists" section"""
 
-    def __init__(self, data: dict | None = None):
-        if data is None:
-            self.i = web.input(workId="", editionId="")
-            self.data = {
-                "workId": self.i.workId,
-                "editionId": self.i.editionId,
-            }
+    def __init__(self, workId: str = "", editionId: str = ""):
+        if not workId and not editionId:
+            # Only read from web.input if no params provided
+            i = web.input(workId="", editionId="")
+            self.workId = i.workId
+            self.editionId = i.editionId
         else:
-            self.data = data
+            self.workId = workId
+            self.editionId = editionId
 
     def generate(self) -> dict:
         results: dict = {"partials": []}
-        work_key = self.data.get("workId", "")
-        edition_key = self.data.get("editionId", "")
-        keys = [k for k in (work_key, edition_key) if k]
+        keys = [k for k in (self.workId, self.editionId) if k]
 
         # Do checks and render
         lists = get_lists(keys)