fix: migrate registration newsletter to native HTML checkbox

Author: akramcodez

openlibrary/plugins/upstream/forms.py

@@ -112,14 +112,6 @@ class RegisterForm(Form):
             maxlength="20",
             required="true",
         ),
-        Checkbox(
-            'ia_newsletter',
-            description=_(
-                'I want to receive news, announcements, and resources from the '
-                '<a href="https://archive.org/">Internet Archive</a>, the non-profit '
-                'that runs Open Library.'
-            ),
-        ),
         Checkbox(
             "pd_request",
             description=_(

openlibrary/templates/account/create.html

@@ -76,7 +76,12 @@ <h1 class="ol-signup-hero__title">$_("Sign Up")</h1>
             $:field(form.password)
 
             <div class="ol-signup-form__checkbox">
-                $:form.ia_newsletter.render() <label for="ia_newsletter">$:form.ia_newsletter.description</label>
+                <input type="checkbox" id="ia_newsletter" name="ia_newsletter"/>
+                <label for="ia_newsletter">
+                    I want to receive news, announcements, and resources from the 
+                    <a href="https://archive.org/">Internet Archive</a>, 
+                    the non-profit that runs Open Library.
+                </label>
             </div>
             <div id="rpd-checkbox" class="ol-signup-form__checkbox">
                 $:form.pd_request.render() <label for="pd_request">$:form.pd_request.description</label>