Address code review feedback: use work.url() and pass bulk explicitly

Co-authored-by: mekarpeles <978325+mekarpeles@users.noreply.github.com>

Author: Copilot

openlibrary/plugins/openlibrary/api.py

@@ -620,8 +620,7 @@ def GET(self):
 class work_delete(delegate.page):
     path = r"/works/(OL\d+W)/[^/]+/delete"
 
-    def get_editions_of_work(self, work: Work) -> list[dict]:
-        i = web.input(bulk=False)
+    def get_editions_of_work(self, work: Work, bulk: bool = False) -> list[dict]:
         limit = 1_000  # This is the max limit of the things function
         all_keys: list = []
         offset = 0
@@ -637,7 +636,7 @@ def get_editions_of_work(self, work: Work) -> list[dict]:
             )
             all_keys.extend(keys)
             if len(keys) == limit:
-                if not i.bulk:
+                if not bulk:
                     raise web.HTTPError(
                         '400 Bad Request',
                         data=json.dumps(
@@ -668,7 +667,7 @@ def POST(self, work_id: str):
         if work is None:
             return web.HTTPError(status='404 Not Found')
 
-        editions: list[dict] = self.get_editions_of_work(work)
+        editions: list[dict] = self.get_editions_of_work(work, bulk=bulk)
 
         # Check if super-librarian is required for bulk operations with 1000+ editions
         if bulk and len(editions) >= 1_000 and not (user and user.is_super_librarian()):

openlibrary/templates/books/edit.html

@@ -39,16 +39,14 @@
     $if ctx.user and (ctx.user.is_admin() or ctx.user.is_super_librarian()):
         <span class="adminOnly right">
             $if work and work.key:
-                $ work_id = work.key.split('/')[-1]
-                $ work_title_slug = work.title.replace(' ', '_') if work.title else 'untitled'
-                <form method="post" action="/works/$work_id/$work_title_slug/delete?bulk=true" id="delete-work-and-editions" name="delete-work" onsubmit="return confirm('Delete work and all of its editions?')" style="display: inline;">
+                <form method="post" action="$work.url(suffix='/delete', bulk='true')" id="delete-work-and-editions" name="delete-work" onsubmit="return confirm('Delete work and all of its editions?')" style="display: inline;">
                     <button type="submit" name="_delete_work" value="true" id="delete-work-btn">$_("Delete work and all editions")</button>
                 </form>
             $if edition:
                 <form method="post" id="delete-record" name="delete" style="display: inline;">
                     <button type="submit" name="_delete" value="true" id="delete-btn">$_("Delete edition")</button>
                 </form>
-            $elif not edition:
+            $else:
                 <form method="post" id="delete-record" name="delete" style="display: inline;">
                     <button type="submit" name="_delete" value="true" id="delete-btn">$_("Delete Record")</button>
                 </form>