Skip to content

Commit 43e1a7e

Browse files
authored
refactor: Clean up unused templates (#11604)
* remove: delete unused book cover templates for single edition and work * remove: eliminate unused references to the single edition book cover template in legacy CSS * remove: delete unused book cover templates for single edition and work, and clean up legacy CSS references
1 parent c54efb2 commit 43e1a7e

File tree

6 files changed

+10
-165
lines changed

6 files changed

+10
-165
lines changed

openlibrary/i18n/messages.pot

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,7 @@ msgstr ""
117117

118118
#: BookPreview.html CreateListModal.html DonateModal.html NotesModal.html
119119
#: ObservationsModal.html ShareModal.html covers/author_photo.html
120-
#: covers/book_cover.html covers/book_cover_single_edition.html
121-
#: covers/book_cover_work.html covers/change.html lib/history.html
120+
#: covers/book_cover.html covers/change.html lib/history.html
122121
#: my_books/check_ins/check_in_prompt.html my_books/dropdown_content.html
123122
#: native_dialog.html
124123
msgid "Close"
@@ -366,8 +365,8 @@ msgid "Loading indicator"
366365
msgstr ""
367366

368367
#: LoanReadForm.html ReadButton.html admin/inspect/memcache.html
369-
#: book_providers/read_button.html books/edit/edition.html books/show.html
370-
#: books/works-show.html trending.html type/list/embed.html widget.html
368+
#: book_providers/read_button.html books/edit/edition.html trending.html
369+
#: type/list/embed.html widget.html
371370
msgid "Read"
372371
msgstr ""
373372

@@ -1827,9 +1826,7 @@ msgstr ""
18271826
msgid "Revision %d"
18281827
msgstr ""
18291828

1830-
#: books/check.html books/show.html covers/book_cover.html
1831-
#: covers/book_cover_single_edition.html covers/book_cover_work.html diff.html
1832-
#: jsdef/LazyWorkPreview.html
1829+
#: books/check.html covers/book_cover.html diff.html jsdef/LazyWorkPreview.html
18331830
msgid "by"
18341831
msgstr ""
18351832

@@ -2822,8 +2819,8 @@ msgstr ""
28222819
msgid "Publish date unknown"
28232820
msgstr ""
28242821

2825-
#: account/notes.html books/edition-sort.html books/works-show.html
2826-
#: lists/export_as_html.html type/work/editions.html
2822+
#: account/notes.html books/edition-sort.html lists/export_as_html.html
2823+
#: type/work/editions.html
28272824
msgid "Publisher unknown"
28282825
msgstr ""
28292826

@@ -5468,25 +5465,19 @@ msgstr ""
54685465
msgid "Pull up a bigger book cover"
54695466
msgstr ""
54705467

5471-
#: covers/book_cover.html covers/book_cover_single_edition.html
5472-
#: covers/book_cover_small.html covers/book_cover_work.html
5468+
#: covers/book_cover.html covers/book_cover_small.html
54735469
#, python-format
54745470
msgid "Cover of: %(title)s by %(authors)s"
54755471
msgstr ""
54765472

5477-
#: covers/book_cover_single_edition.html covers/book_cover_work.html
5478-
msgid "View a larger book cover"
5479-
msgstr ""
5480-
5481-
#: covers/book_cover_single_edition.html covers/book_cover_small.html
5482-
#: covers/book_cover_work.html
5473+
#: covers/book_cover_small.html
54835474
#, python-format
5484-
msgid "We need a book cover for: %(title)s"
5475+
msgid "Go to the main page for %(title)s"
54855476
msgstr ""
54865477

54875478
#: covers/book_cover_small.html
54885479
#, python-format
5489-
msgid "Go to the main page for %(title)s"
5480+
msgid "We need a book cover for: %(title)s"
54905481
msgstr ""
54915482

54925483
#: covers/change.html

openlibrary/templates/books/show.html

Lines changed: 0 additions & 34 deletions
This file was deleted.

openlibrary/templates/books/works-show.html

Lines changed: 0 additions & 38 deletions
This file was deleted.

openlibrary/templates/covers/book_cover_single_edition.html

Lines changed: 0 additions & 34 deletions
This file was deleted.

openlibrary/templates/covers/book_cover_work.html

Lines changed: 0 additions & 30 deletions
This file was deleted.

static/css/legacy.less

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,7 +1188,6 @@ ul {
11881188

11891189
// openlibrary/macros/CoverImage.html
11901190
// openlibrary/templates/covers/book_cover.html
1191-
// openlibrary/templates/covers/book_cover_single_edition.html
11921191
.BookTitle {
11931192
position: absolute;
11941193
top: 50%;
@@ -1204,7 +1203,6 @@ ul {
12041203
}
12051204

12061205
// openlibrary/templates/covers/book_cover.html
1207-
// openlibrary/templates/covers/book_cover_single_edition.html
12081206
.Author {
12091207
color: @grey;
12101208
font-style: italic;
@@ -1213,8 +1211,6 @@ ul {
12131211
}
12141212

12151213
// openlibrary/macros/SearchResultsWork.html
1216-
// openlibrary/templates/books/show.html
1217-
// openlibrary/templates/books/works-show.html
12181214
// openlibrary/templates/type/list/embed.html
12191215
span.actions {
12201216
display: block;
@@ -1302,8 +1298,6 @@ ul.list-books {
13021298
}
13031299
// openlibrary/macros/SearchResultsWork.html
13041300
// openlibrary/templates/books/check.html
1305-
// openlibrary/templates/books/show.html
1306-
// openlibrary/templates/books/works-show.html
13071301
// openlibrary/templates/lists/preview.html
13081302
// openlibrary/templates/lists/snippet.html
13091303
// openlibrary/templates/type/list/embed.html
@@ -1320,16 +1314,12 @@ ul.list-books {
13201314
// `span.resultPublisher` is used in
13211315
// * openlibrary/macros/SearchResultsWork.htm
13221316
// * openlibrary/templates/books/check.html
1323-
// * openlibrary/templates/books/show.html
1324-
// * openlibrary/templates/books/works-show.html
13251317
.resultTitle .bookauthor,
13261318
span.resultPublisher {
13271319
font-size: 0.75em;
13281320
color: @grey;
13291321
font-family: @body-family;
13301322
}
1331-
// openlibrary/templates/books/works-show.html
1332-
// openlibrary/templates/books/show.html
13331323
// openlibrary/templates/books/check.html
13341324
// openlibrary/macros/SearchResultsWork.html
13351325
span.resultPublisher {

0 commit comments

Comments
 (0)