Skip to content

Commit 56836d1

Browse files
committed
Remove remaining gitpod references from codebase
1 parent 1aa4850 commit 56836d1

File tree

10 files changed

+4
-52
lines changed

10 files changed

+4
-52
lines changed

Readme.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@ Run `docker compose up` and visit http://localhost:8080
4444
Need more details? Checkout the [Docker instructions](https://github.com/internetarchive/openlibrary/blob/master/docker/README.md)
4545
or [video tutorial](https://archive.org/embed/openlibrary-developer-docs/openlibrary-docker-set-up.mp4).
4646

47-
***Alternatively***, if you do not want to set up Open Library on your local computer, try Gitpod!
48-
This lets you work on Open Library entirely in your browser without having to install anything on your personal computer.
49-
Warning: This integration is still experimental.
50-
[![Open In Gitpod](https://img.shields.io/badge/Contribute%20with-Gitpod-908a85?logo=gitpod)](https://gitpod.io/#https://github.com/internetarchive/openlibrary/)
5147

5248
### Developer's Guide
5349

Readme_chinese.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@
4242
需要更多信息?请查看 [Docker指南](https://github.com/internetarchive/openlibrary/blob/master/docker/README.md)
4343
或者[视频教程](https://archive.org/embed/openlibrary-developer-docs/openlibrary-docker-set-up.mp4)
4444

45-
***或者***,如果您不想在本地的电脑上安装公共图书馆,您可以尝试Gitpod!这可以让您在不安装任何插件的前提下,在浏览器中使用公共图书馆。警告:此集成仍在实验中。
46-
[![Open In Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/internetarchive/openlibrary/)
47-
4845
### 给开发者的指南
4946

5047
有关管理公共图书馆实例的说明,请参考开发者的[快速入门](https://github.com/internetarchive/openlibrary/wiki/Getting-Started)指南。

Readme_es.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ Ejecuta `docker compose up` y visita http://localhost:8080
4343
¿Necesitas más detalles? Checa las [Instrucciones de Docker](https://github.com/internetarchive/openlibrary/blob/master/docker/README.md)
4444
o el [video tutorial](https://archive.org/embed/openlibrary-developer-docs/openlibrary-docker-set-up.mp4).
4545

46-
***Alternativamente***, Si no quieres montar Open Library en tu computadora local, prueba Gitpod!
47-
Esto te deja trabajar en Open Library enteramente desde tu navegador sin tener que instalar nada en tu computadora personal.
48-
Advertencia: Esta integración sigue siendo experimental.
49-
[![Ábrelo en Gitpod](https://img.shields.io/badge/Contribute%20with-Gitpod-908a85?logo=gitpod)](https://gitpod.io/#https://github.com/internetarchive/openlibrary/)
50-
5146
### Guía de Desarrollador
5247

5348
También puedes encontrar más información sobre la Documentación para Desarrolladores de Open Library en la [Wiki](https://github.com/internetarchive/openlibrary/wiki/) de Open Library.

Readme_vn.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ Chạy `docker compose up` và truy cập http://localhost:8080
4242
Cần thêm chi tiết? Xem thử [Docker instructions](https://github.com/internetarchive/openlibrary/blob/master/docker/README.md)
4343
hoặc [video hướng dẫn](https://archive.org/embed/openlibrary-developer-docs/openlibrary-docker-set-up.mp4).
4444

45-
***Ngoài ra***, nếu bạn không muốn thiết lập Open Library trên máy tính cá nhân của mình, hãy thử sử dụng Gitpod! Điều này cho phép bạn làm việc với Open Library hoàn toàn trong trình duyệt mà không cần cài đặt bất kỳ thứ gì trên máy tính cá nhân.
46-
Cảnh báo: Việc tích hợp này vẫn đang trong giai đoạn thử nghiệm.
47-
[![Open In Gitpod](https://img.shields.io/badge/Contribute%20with-Gitpod-908a85?logo=gitpod)](https://gitpod.io/#https://github.com/internetarchive/openlibrary/)
48-
4945
### Hướng dẫn dành cho nhà phát triển
5046

5147
Bạn cũng có thể tìm kiếm thêm thông tin về Tài liệu dành cho nhà phát triển của Open Library trong chính Open Library [Wiki](https://github.com/internetarchive/openlibrary/wiki/).

docker/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
# Welcome to the Installation Guide for Open Library Developers
22

3-
> [!TIP]
4-
> Want to try Open Library in your browser without having to install anything on your personal computer? Try (experimental) Gitpod integration! [![Open In Gitpod](https://img.shields.io/badge/Contribute%20with-Gitpod-908a85?logo=gitpod)](https://gitpod.io/#https://github.com/internetarchive/openlibrary/)
5-
63
1. [Pull code locally](#pull-code-locally)
74
2. [Install Docker](#install-docker) and [Test Docker](#test-docker)
85
3. [Prepare your system](#prepare-your-system)

openlibrary/plugins/openlibrary/js/service-worker-matchers.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ export function matchStaticImages({ url }) {
3131
export function matchStaticBuild({ url }) {
3232
const regex = /^\/static\/build\/.*(\.js|\.css)/;
3333
const localhost = url.origin.includes('localhost')
34-
const gitpod = url.origin.includes('gitpod')
35-
return !localhost && !gitpod && regex.test(url.pathname);
34+
return !localhost && regex.test(url.pathname);
3635
}
3736

3837
export function matchArchiveOrgImage({ url }) {

openlibrary/plugins/upstream/code.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747

4848

4949
# Note: This is done in web_nginx.conf on production ; this endpoint is
50-
# only used in development/gitpod.
50+
# only used in development environments.
5151
class static(delegate.page):
5252
path = "/images/.*"
5353

scripts/setup_gitpod.sh

Lines changed: 0 additions & 8 deletions
This file was deleted.

tests/unit/js/service-worker-matchers.test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,8 @@ describe('URL Matchers', () => {
6161
expect(matchStaticBuild(_u('https://testing.openlibrary.org/static/build/css/page-book.css?v=097b69dc350c972d96da0c70cebe7b75'))).toBe(true);
6262
});
6363

64-
test('does not match localhost or gitpod URLs', () => {
64+
test('does not match localhost URLs', () => {
6565
expect(matchStaticBuild(_u('http://localhost:8080/static/build/js/4290.a0ae80aacde14696d322.js'))).toBe(false);
66-
expect(matchStaticBuild(_u('https://8080-internetarc-openlibrary-feliyig0grl.ws-eu110.gitpod.io/static/build/js/4290.a0ae80aacde14696d322.js'))).toBe(false);
6766
});
6867
});
6968

vue.config.js

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,5 @@
11
/* eslint-env node, es6 */
22
module.exports = {
33
lintOnSave: false,
4-
publicPath: '/static/components/',
5-
6-
// Add support for running from gitpod
7-
...(process.env.GITPOD_WORKSPACE_ID ? {
8-
devServer: {
9-
allowedHosts: [
10-
// It'll pick the first free one, so will be 8080 if OL not running, otherwise 8081.
11-
// The rest are just in case/if you run multiple
12-
`8080-${process.env.GITPOD_WORKSPACE_ID}.${process.env.GITPOD_WORKSPACE_CLUSTER_HOST}`,
13-
`8081-${process.env.GITPOD_WORKSPACE_ID}.${process.env.GITPOD_WORKSPACE_CLUSTER_HOST}`,
14-
`8082-${process.env.GITPOD_WORKSPACE_ID}.${process.env.GITPOD_WORKSPACE_CLUSTER_HOST}`,
15-
`8083-${process.env.GITPOD_WORKSPACE_ID}.${process.env.GITPOD_WORKSPACE_CLUSTER_HOST}`,
16-
],
17-
client: {
18-
webSocketURL: {
19-
port: 443,
20-
},
21-
},
22-
},
23-
} : {}),
4+
publicPath: '/static/components/'
245
};

0 commit comments

Comments
 (0)