Skip to content

Commit 910d4d1

Browse files
Copilotmekarpeles
andcommitted
Fix sitemap generation bug in oldump.sh
Remove conditional check that prevented sitemap regeneration on subsequent runs. The script now always removes and recreates the sitemaps directory, ensuring sitemaps are generated for each dump run instead of only on the first run. Fixes issue where sitemaps were only generated when --overwrite was specified or on the very first run, causing 404 errors on sitemap URLs. Co-authored-by: mekarpeles <978325+mekarpeles@users.noreply.github.com>
1 parent bc653c8 commit 910d4d1

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

scripts/oldump.sh

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -220,18 +220,13 @@ fi
220220
# =================
221221
# Generate Sitemaps
222222
# =================
223-
if [[ ! -d $TMPDIR/sitemaps ]]
224-
then
225-
log "generating sitemaps"
226-
mkdir -p $TMPDIR/sitemaps
227-
rm -fr $TMPDIR/sitemaps/*
228-
cd $TMPDIR/sitemaps
229-
time python $SCRIPTS/sitemaps/sitemap.py $TMPDIR/dumps/$dump/$dump.txt.gz > sitemaps.log
230-
# rm -fr $TMPDIR/sitemaps
231-
ls -lh
232-
else
233-
log "Skipping sitemaps"
234-
fi
223+
log "generating sitemaps"
224+
rm -rf $TMPDIR/sitemaps
225+
mkdir -p $TMPDIR/sitemaps
226+
cd $TMPDIR/sitemaps
227+
time python $SCRIPTS/sitemaps/sitemap.py $TMPDIR/dumps/$dump/$dump.txt.gz > sitemaps.log
228+
# rm -fr $TMPDIR/sitemaps
229+
ls -lh
235230

236231
log "$USER has completed $@ in $TMPDIR on ${HOSTNAME:-$HOST}"
237232

0 commit comments

Comments
 (0)