Update disposable email check

jimchamp · web-flow · commit b19ba14909d3 · 2024-12-17T15:54:32.000-08:00
Ensures that we are only invalidating emails from `dispostable.com`.
Without this change, emails from domains like `not-so-dispostable.com` would be blocked.
diff --git a/openlibrary/plugins/upstream/forms.py b/openlibrary/plugins/upstream/forms.py
@@ -44,7 +44,7 @@ def find_ia_account(email=None):
 )
 email_not_disposable = Validator(
     _("Disposable email not permitted"),
-    lambda email: not email.lower().endswith('dispostable.com'),
+    lambda email: not email.lower().endswith('@dispostable.com'),
 )
 email_domain_not_blocked = Validator(
     _("Your email provider is not recognized."),

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def find_ia_account(email=None):`
`44`	`44`	`)`
`45`	`45`	`email_not_disposable = Validator(`
`46`	`46`	`_("Disposable email not permitted"),`
`47`		`- lambda email: not email.lower().endswith('dispostable.com'),`
	`47`	`+ lambda email: not email.lower().endswith('@dispostable.com'),`
`48`	`48`	`)`
`49`	`49`	`email_domain_not_blocked = Validator(`
`50`	`50`	`_("Your email provider is not recognized."),`