[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Author: pre-commit-ci[bot]

openlibrary/i18n/messages.pot

@@ -5820,6 +5820,26 @@ msgstr ""
 msgid "%s does not exist."
 msgstr ""
 
+#: lib/challenge.html
+msgid "Human Verification"
+msgstr ""
+
+#: lib/challenge.html
+msgid "Please verify you are human to continue."
+msgstr ""
+
+#: lib/challenge.html
+msgid "Verify you are human"
+msgstr ""
+
+#: lib/challenge.html
+msgid "Verifying..."
+msgstr ""
+
+#: lib/challenge.html
+msgid "Verification failed. Please try again."
+msgstr ""
+
 #: lib/edit_head.html lib/view_head.html
 msgid "This doc was last edited by"
 msgstr ""

openlibrary/plugins/openlibrary/code.py

@@ -14,11 +14,11 @@
 from time import time
 from urllib.parse import parse_qs, urlencode
 
-import infogami
 import requests
 import web
 import yaml
 
+import infogami
 from openlibrary.core import db
 from openlibrary.core.batch_imports import (
     batch_import,
@@ -35,6 +35,7 @@
     infogami.config.features = []  # type: ignore[attr-defined]
 
 
+import openlibrary.core.stats
 from infogami.core.db import ValidationException
 from infogami.infobase import client
 from infogami.utils import delegate, features
@@ -46,8 +47,6 @@
     render_template,
     safeint,
 )
-
-import openlibrary.core.stats
 from openlibrary.core.lending import get_availability
 from openlibrary.core.models import Edition
 from openlibrary.plugins.openlibrary import processors
@@ -1229,9 +1228,11 @@ def is_bot():
     """Check if the current request is from a bot."""
     return req_context.get().is_bot
 
+
 def is_recognized_bot():
     return req_context.get().is_recognized_bot
 
+
 def is_suspicious_visitor():
     """Check if the current visitor is suspicious and needs human verification.
 
@@ -1251,7 +1252,7 @@ def is_suspicious_visitor():
     # Check if there's a referer header
     if web.ctx.env.get('HTTP_REFERER'):
         return False
-    
+
     # Check if visitor has already been verified (has vf=1 cookie)
     if web.cookies().get('vf') == '1':
         return False
@@ -1264,6 +1265,7 @@ def is_suspicious_visitor():
         pass
     return True
 
+
 def require_human_verification():
     """Show the human verification challenge page.
 

openlibrary/plugins/openlibrary/tests/test_verification.py

@@ -1,6 +1,5 @@
 """Tests for human verification challenge functionality."""
 
-import pytest
 import web
 
 from openlibrary.mocks.mock_infobase import MockSite
@@ -35,6 +34,7 @@ def test_is_suspicious_visitor_when_logged_in(self, monkeypatch):
         # Mock no verification cookie
         def mock_cookies():
             return {}
+
         monkeypatch.setattr(web, 'cookies', mock_cookies)
 
         assert code.is_suspicious_visitor() is False
@@ -50,6 +50,7 @@ def test_is_suspicious_visitor_when_bot(self, monkeypatch):
         # Mock no verification cookie
         def mock_cookies():
             return {}
+
         monkeypatch.setattr(web, 'cookies', mock_cookies)
 
         assert code.is_suspicious_visitor() is False
@@ -65,6 +66,7 @@ def test_is_suspicious_visitor_with_cookie(self, monkeypatch):
         # Mock verification cookie present
         def mock_cookies():
             return {'vf': '1'}
+
         monkeypatch.setattr(web, 'cookies', mock_cookies)
 
         assert code.is_suspicious_visitor() is False
@@ -80,6 +82,7 @@ def test_is_suspicious_visitor_when_all_checks_fail(self, monkeypatch):
         # Mock no verification cookie
         def mock_cookies():
             return {}
+
         monkeypatch.setattr(web, 'cookies', mock_cookies)
 
         assert code.is_suspicious_visitor() is True
@@ -95,6 +98,7 @@ def test_is_suspicious_visitor_with_wrong_cookie_value(self, monkeypatch):
         # Mock verification cookie with wrong value
         def mock_cookies():
             return {'vf': '0'}
+
         monkeypatch.setattr(web, 'cookies', mock_cookies)
 
         assert code.is_suspicious_visitor() is True

openlibrary/plugins/upstream/account.py

@@ -9,9 +9,10 @@
 from typing import TYPE_CHECKING, Any, Final
 from urllib.parse import urlparse
 
-import infogami.core.code as core  # noqa: F401 side effects may be needed
 import requests
 import web
+
+import infogami.core.code as core  # noqa: F401 side effects may be needed
 from infogami import config
 from infogami.utils import delegate
 from infogami.utils.view import (
@@ -20,7 +21,6 @@
     render_template,
     require_login,
 )
-
 from openlibrary import accounts
 from openlibrary.accounts import (
     InternetArchiveAccount,
@@ -1309,8 +1309,9 @@ class account_verify_human(delegate.page):
 
     Sets the vf=1 cookie and redirects back to the original URL.
     """
+
     path = "/account/verify_human"
-    
+
     # Cookie expires in 30 days
     VERIFICATION_COOKIE_EXPIRES_SECONDS = 30 * 24 * 60 * 60
 

openlibrary/plugins/worksearch/code.py

@@ -13,12 +13,12 @@
 
 import httpx
 import web
+from requests import Response
+
 from infogami import config
 from infogami.infobase.client import storify
 from infogami.utils import delegate
 from infogami.utils.view import public, render, render_template, safeint
-from requests import Response
-
 from openlibrary.core import cache
 from openlibrary.core.lending import add_availability
 from openlibrary.core.models import Edition
@@ -717,7 +717,11 @@ def GET(self):
 
         # Check if this is an expensive search that requires human verification
         if self._is_expensive_search(i):
-            from openlibrary.plugins.openlibrary.code import is_suspicious_visitor, require_human_verification
+            from openlibrary.plugins.openlibrary.code import (
+                is_suspicious_visitor,
+                require_human_verification,
+            )
+
             if is_suspicious_visitor():
                 return require_human_verification()
 

openlibrary/plugins/worksearch/subjects.py

@@ -6,11 +6,11 @@
 from typing import cast
 
 import web
+from typing_extensions import deprecated
+
 from infogami.plugins.api.code import jsonapi
 from infogami.utils import delegate
 from infogami.utils.view import render_template, safeint
-from typing_extensions import deprecated
-
 from openlibrary.core.lending import add_availability
 from openlibrary.core.models import Subject, Tag
 from openlibrary.solr.query_utils import query_dict_to_str
@@ -30,7 +30,11 @@ class subjects(delegate.page):
 
     def GET(self, key):
         # Check if human verification is needed for subject pages
-        from openlibrary.plugins.openlibrary.code import is_suspicious_visitor, require_human_verification
+        from openlibrary.plugins.openlibrary.code import (
+            is_suspicious_visitor,
+            require_human_verification,
+        )
+
         if is_suspicious_visitor():
             return require_human_verification()
 

openlibrary/plugins/worksearch/tests/test_verification.py

@@ -7,21 +7,21 @@
 
 class TestSearchVerification:
     """Tests for search expensive query detection."""
-    
+
     def setup_method(self):
         """Setup test fixtures."""
         self.search_handler = search()
-    
+
     def test_is_expensive_search_with_language_colon(self):
         """Test detection of language: syntax."""
         i = web.storage(q='language:eng')
         assert self.search_handler._is_expensive_search(i) is True
-    
+
     def test_is_expensive_search_empty_query(self):
         """Test that empty queries are not marked as expensive."""
         i = web.storage(q='')
         assert self.search_handler._is_expensive_search(i) is False
-    
+
     def test_is_expensive_search_no_query(self):
         """Test handling when no query parameter exists."""
         i = web.storage()

openlibrary/utils/request_context.py

@@ -88,10 +88,12 @@ class RequestContextVars:
     'icc-crawler',
 ]
 
+
 def _compute_is_recognized_bot(user_agent: str) -> bool:
     my_ua = user_agent.lower()
     return any(ua in my_ua for ua in USER_AGENT_BOTS)
 
+
 def _compute_is_bot(user_agent: str | None, hhcl: str | None) -> bool:
     """Determine if the request is from a bot.
 
@@ -102,7 +104,7 @@ def _compute_is_bot(user_agent: str | None, hhcl: str | None) -> bool:
     Returns:
         True if the request appears to be from a bot, False otherwise
     """
-    
+
     # Check hhcl header first (set by nginx)
     if hhcl == '1':
         return True
@@ -113,6 +115,7 @@ def _compute_is_bot(user_agent: str | None, hhcl: str | None) -> bool:
 
     return _compute_is_recognized_bot(user_agent)
 
+
 def _parse_solr_editions_from_web() -> bool:
     """Parse solr_editions from web.py context."""