Skip to content

Commit f3ae7af

Browse files
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
1 parent e0bb8f7 commit f3ae7af

2 files changed

Lines changed: 14 additions & 13 deletions

File tree

openlibrary/core/lists/model.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -696,8 +696,7 @@ def get_work_sort_key(
696696
with contextlib.suppress(ValueError):
697697
return ("A: Numeric", 1, int(float(pos_str)), work.key)
698698

699-
match = re.fullmatch(r'(\d+)\s*[-–]\s*(\d+)', pos_str)
700-
if match:
699+
if match := re.fullmatch(r'(\d+)\s*[-–]\s*(\d+)', pos_str):
701700
lower = int(match.group(1))
702701
upper = int(match.group(2))
703702
return ("C: Range", upper - lower, lower, work.key)

openlibrary/tests/core/lists/test_model.py

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
import web
2+
13
import openlibrary.core.lists.model as list_model
24
from openlibrary.mocks.mock_infobase import MockSite
3-
import web
45

56

67
class TestList:
@@ -29,6 +30,7 @@ def save_doc(self, site, type, key, **fields):
2930
d.update(fields)
3031
site.save(d)
3132

33+
3234
class MockWork:
3335
def __init__(self, key, position):
3436
self.key = key
@@ -73,17 +75,17 @@ def test_series_sorting(self, monkeypatch):
7375

7476
result_keys = [seed.key for seed in seeds]
7577
expected_keys = [
76-
"/works/OL2W", # 1
77-
"/works/OL5W", # 2
78+
"/works/OL2W", # 1
79+
"/works/OL5W", # 2
7880
"/works/OL11W", # 3 (tie-break by work key)
79-
"/works/OL3W", # 3
81+
"/works/OL3W", # 3
8082
"/works/OL10W", # None -> non-numeric bucket
81-
"/works/OL8W", # Non-numeric
82-
"/works/OL7W", # 4-5 (range size 1, lower 4)
83-
"/works/OL1W", # 22-23 (range size 1, lower 22)
84-
"/works/OL4W", # 24-25 (range size 1, lower 24)
85-
"/works/OL6W", # 1-3 (range size 2, lower 1)
86-
"/works/OL9W", # 1-9 (range size 8, lower 1)
83+
"/works/OL8W", # Non-numeric
84+
"/works/OL7W", # 4-5 (range size 1, lower 4)
85+
"/works/OL1W", # 22-23 (range size 1, lower 22)
86+
"/works/OL4W", # 24-25 (range size 1, lower 24)
87+
"/works/OL6W", # 1-3 (range size 2, lower 1)
88+
"/works/OL9W", # 1-9 (range size 8, lower 1)
8789
]
8890

89-
assert result_keys == expected_keys
91+
assert result_keys == expected_keys

0 commit comments

Comments
 (0)