Merge pull request #11389 from SAYAN02-DEV/fix-loading-indicator

jimchamp · web-flow · commit f8f2b56f0f04 · 2025-11-04T15:58:59.000-08:00
Fix: Hide loading indicator if carousel loading fails.
diff --git a/openlibrary/plugins/openlibrary/js/lazy-carousel.js b/openlibrary/plugins/openlibrary/js/lazy-carousel.js
@@ -82,6 +82,7 @@ function doFetchAndUpdate(target) {
             }
         })
         .catch(() => {
+            loadingIndicator.classList.add('hidden');
             const retryElem = target.querySelector('.lazy-carousel-retry')
             retryElem.classList.remove('hidden')
         })

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,7 @@ function doFetchAndUpdate(target) {`
`82`	`82`	`}`
`83`	`83`	`})`
`84`	`84`	`.catch(() => {`
	`85`	`+ loadingIndicator.classList.add('hidden');`
`85`	`86`	`const retryElem = target.querySelector('.lazy-carousel-retry')`
`86`	`87`	`retryElem.classList.remove('hidden')`
`87`	`88`	`})`