Invalid list keys are being added to lists

[jimchamp]

Problem

Somehow, people have been able to insert the key {"key": ""} into their lists. If a list contains one of these invalid keys, the list's page will fail to render with an error. Similarly, the book page lists section will not render if one of the lists being displayed has an invalid key.

Here is a page for a list that contains an invalid key.

Here is an example of the book page "Lists" section failing to render due to this issue.

Reproducing the bug

1. Go to ...
2. Do ...

• Expected behavior:
• Actual behavior:

Context

• Browser (Chrome, Safari, Firefox, etc):
• OS (Windows, Mac, etc):
• Logged in (Y/N):
• Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

• Find and fix bug that allows a list to contain an invalid key
• Identify affected lists
• Remove invalid keys from affected lists (likely requires staff)

Related files

Stakeholders

---

Instructions for Contributors

• Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

[akramcodez]

@jimchamp Hey! I can work on this.

Proposed approach:

1. Add validation to reject empty keys at insertion points
2. Create cleanup script to remove existing invalid keys
3. Add tests to prevent regression

[RayBB]

@jimchamp where do you see the {"key": ""} bit? I looked at the list json and don't see it there.

https://openlibrary.org/people/luanna_tumark/lists/OL316621L.json

I do see that the seeds endpoint fails completely:

https://openlibrary.org/people/luanna_tumark/lists/OL316621L/seeds.json

[cdrini]

You can see it here: https://openlibrary.org/people/luanna_tumark/lists/OL316621L.json?_raw=true