-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Labels
Lead: @RayBBIssues overseen by Ray (Onboarding & Documentation Lead) [manages]Issues overseen by Ray (Onboarding & Documentation Lead) [manages]Theme: DevelopmentIssues related to the developer experience and the dev environment. [managed]Issues related to the developer experience and the dev environment. [managed]
Description
Pre-commit rules have been stuck not updating since September!
I tried to fix warning it gives about RUF059 but it's pretty hard to isolate the changes that need manual review. There are ~15 files that need manual review for fixes for this issue. But as soon as you make those fixes pre-commit will also fix all the other 100 files with small changes that it has since made.
My solutions is as follows:
- Disable the rule disable ruff RUF059 #11746
- Update pre-commit with all automatic fixes [pre-commit.ci] pre-commit autoupdate #11273
- Re-enable the rule and manually address warnings enable RUF059 #11764
- Bonus: remove UP038 from the config since it will be no longer part of Ruff remove deprecated rule UP038 #11763
This issue can be closed when all three have been completed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Lead: @RayBBIssues overseen by Ray (Onboarding & Documentation Lead) [manages]Issues overseen by Ray (Onboarding & Documentation Lead) [manages]Theme: DevelopmentIssues related to the developer experience and the dev environment. [managed]Issues related to the developer experience and the dev environment. [managed]
Type
Projects
Status
No status