Skip to content

refactor: remove mixins.less. flex browser-prefixes not needed#11473

Merged
jimchamp merged 4 commits intointernetarchive:masterfrom
lokesh:refactor/remove-mixins-less
Dec 3, 2025
Merged

refactor: remove mixins.less. flex browser-prefixes not needed#11473
jimchamp merged 4 commits intointernetarchive:masterfrom
lokesh:refactor/remove-mixins-less

Conversation

@lokesh
Copy link
Collaborator

@lokesh lokesh commented Nov 15, 2025

As I've been looking at the current the CSS organization I've been finding some low hanging fruit for clean up. In following process, in the future I'll create a Github Issue that captures this work.

This PR deletes static/css/less/mixins.less

Technical

In the file were two mixins:

.display-flex() {
  display: -webkit-box;
  display: -ms-flexbox;
  display: -webkit-flex;
  display: flex;
}
.shell-btn--active() {
  background-color: @white;
  border: 2px solid @primary-blue;
  color: @primary-blue;
}
  • .display-flex() - Safari, the last browser to do so, dropped the browser prefix requirement for flex in 2014.
  • .shell-btn--active() - This was only used in one location. I moved the code inline.

Stakeholders

@jimchamp @cdrini @mekarpeles

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lokesh, and sorry for the massive delay. I pushed a commit that removes the display-flex mixin from pagination.less. Will merge this after the workflows finish running.

@jimchamp jimchamp merged commit 1a6a3fe into internetarchive:master Dec 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants