From ad730f02a1ac354ebf50eb72ef0738dd794a7462 Mon Sep 17 00:00:00 2001 From: bettercallok Date: Wed, 31 Dec 2025 23:43:28 +0530 Subject: [PATCH 1/2] Remove unused ia_loaded_id Solr field (ref #11586) --- conf/solr/conf/managed-schema.xml | 2 +- openlibrary/solr/solr_types.py | 2 +- openlibrary/solr/updater/work.py | 20 -------------------- 3 files changed, 2 insertions(+), 22 deletions(-) diff --git a/conf/solr/conf/managed-schema.xml b/conf/solr/conf/managed-schema.xml index 8bc734948b3..0cc3184256f 100644 --- a/conf/solr/conf/managed-schema.xml +++ b/conf/solr/conf/managed-schema.xml @@ -155,7 +155,7 @@ - + diff --git a/openlibrary/solr/solr_types.py b/openlibrary/solr/solr_types.py index 6e4f1cdeb91..22481bdd401 100644 --- a/openlibrary/solr/solr_types.py +++ b/openlibrary/solr/solr_types.py @@ -32,7 +32,7 @@ class SolrDocument(TypedDict): lccn: Optional[list[str]] ia: Optional[list[str]] ia_box_id: Optional[list[str]] - ia_loaded_id: Optional[list[str]] + ia_count: Optional[int] ia_collection: Optional[list[str]] oclc: Optional[list[str]] diff --git a/openlibrary/solr/updater/work.py b/openlibrary/solr/updater/work.py index 36920e42c54..3a0b453ba90 100644 --- a/openlibrary/solr/updater/work.py +++ b/openlibrary/solr/updater/work.py @@ -608,27 +608,9 @@ def language(self) -> set[str]: return {lang for ed in self._solr_editions for lang in ed.language} def build_legacy_ia_fields(self) -> dict: - ia_loaded_id = set() ia_box_id = set() for e in self._editions: - # When do we write these to the actual edition?? This code might - # be dead. - if e.get('ia_loaded_id'): - if isinstance(e['ia_loaded_id'], str): - ia_loaded_id.add(e['ia_loaded_id']) - else: - try: - assert isinstance(e['ia_loaded_id'], list) - assert isinstance(e['ia_loaded_id'][0], str) - except AssertionError: - logger.error( - "AssertionError: ia=%s, ia_loaded_id=%s", - e.get("ia"), - e['ia_loaded_id'], - ) - raise - ia_loaded_id.update(e['ia_loaded_id']) if e.get('ia_box_id'): if isinstance(e['ia_box_id'], str): ia_box_id.add(e['ia_box_id']) @@ -643,8 +625,6 @@ def build_legacy_ia_fields(self) -> dict: doc = {} - if ia_loaded_id: - doc['ia_loaded_id'] = list(ia_loaded_id) if ia_box_id: doc['ia_box_id'] = list(ia_box_id) return doc From 8bdfa62887af72bd8b8e50d4a3c4b73b6e1a969b Mon Sep 17 00:00:00 2001 From: bettercallok Date: Thu, 1 Jan 2026 00:32:13 +0530 Subject: [PATCH 2/2] Regenerate solr_types.py after removing ia_loaded_id --- openlibrary/solr/solr_types.py | 1 - 1 file changed, 1 deletion(-) diff --git a/openlibrary/solr/solr_types.py b/openlibrary/solr/solr_types.py index 22481bdd401..ce8c6cb0ba8 100644 --- a/openlibrary/solr/solr_types.py +++ b/openlibrary/solr/solr_types.py @@ -32,7 +32,6 @@ class SolrDocument(TypedDict): lccn: Optional[list[str]] ia: Optional[list[str]] ia_box_id: Optional[list[str]] - ia_count: Optional[int] ia_collection: Optional[list[str]] oclc: Optional[list[str]]