fix crashing bug for high bin missing values

Author: paulbkoch

shared/libebm/PartitionOneDimensionalBoosting.cpp

@@ -892,16 +892,13 @@ template<bool bHessian, size_t cCompilerScores> class PartitionOneDimensionalBoo
 
       const TreeNode<bHessian, GetArrayScores(cCompilerScores)>* pMissingValueTreeNode = nullptr;
       if(TermBoostFlags_MissingLow & flags) {
-         if(bMissing) {
-            if(!bNominal) {
-               pMissingBin = pBin;
-            }
+         if(bMissing && !bNominal) {
+            pMissingBin = pBin;
          }
       } else if(TermBoostFlags_MissingHigh & flags) {
-         if(bMissing) {
-            if(!bNominal) {
-               pMissingBin = pBin;
-            }
+         if(bMissing && !bNominal) {
+            pMissingBin = pBin;
+            // the concept of TermBoostFlags_MissingHigh does not exist for nominals
             pBin = IndexBin(pBin, cBytesPerBin);
          }
       } else {
@@ -920,7 +917,7 @@ template<bool bHessian, size_t cCompilerScores> class PartitionOneDimensionalBoo
       } while(pBinsEnd != pBin);
 
       if(TermBoostFlags_MissingHigh & flags) {
-         if(bMissing) {
+         if(bMissing && !bNominal) {
             *ppBin = aBins;
             ++ppBin;
          }
@@ -1113,8 +1110,10 @@ template<bool bHessian, size_t cCompilerScores> class PartitionOneDimensionalBoo
             cSlices,
             cBins);
 
-      EBM_ASSERT(!bMissing || 2 <= pBoosterShell->GetInnerTermUpdate()->GetCountSlices(iDimension));
-      EBM_ASSERT(!bMissing || *pBoosterShell->GetInnerTermUpdate()->GetSplitPointer(iDimension) == 1);
+      EBM_ASSERT(
+            error != Error_None || !bMissing || 2 <= pBoosterShell->GetInnerTermUpdate()->GetCountSlices(iDimension));
+      EBM_ASSERT(
+            error != Error_None || !bMissing || *pBoosterShell->GetInnerTermUpdate()->GetSplitPointer(iDimension) == 1);
 
       return error;
    }