Fix for code scanning alert no. 2: Incorrect conversion between integer types (#1147)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Mickaël Misbach <[email protected]>

Author: 3 people

pkg/models/models.go

@@ -112,11 +112,14 @@ func VersionFromString(s string) (*Version, error) {
 	}
 	v := &Version{s: s}
 
-	nanos, err := strconv.ParseUint(string(s), versionBase, 64)
+	nanos, err := strconv.ParseInt(string(s), versionBase, 64)
 	if err != nil {
 		return nil, stacktrace.Propagate(err, "Error parsing version to integer")
 	}
-	v.t = time.Unix(0, int64(nanos))
+	if nanos < 0 {
+		return nil, stacktrace.NewError("Parsed negative value for nanosecond timestamp for version")
+	}
+	v.t = time.Unix(0, nanos)
 	return v, nil
 }
 

pkg/rid/store/cockroach/subscriptions_test.go

@@ -159,7 +159,7 @@ func TestStoreDeleteSubscription(t *testing.T) {
 
 			// Ensure mismatched versions returns nothing
 			sub1BadVersion := *sub1
-			sub1BadVersion.Version, err = dssmodels.VersionFromString("a3cg3tcuhk000")
+			sub1BadVersion.Version, err = dssmodels.VersionFromString("a3cg3tcuhk00")
 			require.NoError(t, err)
 			sub2, err := repo.DeleteSubscription(ctx, &sub1BadVersion)
 			require.NoError(t, err)