Skip to content

Commit 8bcf08c

Browse files
authored
feat: upgrade firebase to v8.10.1 (#75)
* upgrade firebase to v8.10.1 * changed package version to 0.8.0-beta * fixed firebase import typo error * updated CHANGELOG
1 parent 4571c9c commit 8bcf08c

10 files changed

+411
-700
lines changed

CHANGELOG.md

+20-2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,24 @@ Good to have: commit or PR links.
2222
2323
-->
2424

25+
## v0.8.0-beta [#75](https://github.com/interviewstreet/firepad-x/pull/75)
26+
27+
### Changed
28+
29+
- Upgrade firebase to v8
30+
31+
## v0.7.4-beta [#73](https://github.com/interviewstreet/firepad-x/pull/73)
32+
33+
### Added
34+
35+
- `console.error()` for all catch blocks to send events to error tracking service
36+
37+
## v0.7.1-beta [#68](https://github.com/interviewstreet/firepad-x/pull/68)
38+
39+
### Added
40+
41+
- Firestore as Database adapter to allow code sync via firestore
42+
2543
## v0.4.1-beta
2644

2745
No Changes
@@ -30,11 +48,11 @@ No Changes
3048

3149
### Changed
3250

33-
- Fix a bug monaco-adapter/_operationFromMonacoChange function
51+
- Fix a bug monaco-adapter/\_operationFromMonacoChange function
3452
- Revert https://github.com/interviewstreet/firepad-x/commit/2aebf79871d3fc9bf21e9b056a0faa60c6da0b3a
3553
- Revert https://github.com/interviewstreet/firepad-x/commit/a12177892c692b44c106d60f2819fbf7f1094f22
3654
- No breaking change on external APIs.
37-
- Revert to firebase v7.12.0 (https://github.com/interviewstreet/firepad-x/commit/03910ce475e04ddcab2e683877f579bfcbd32d91).
55+
- Revert to firebase v7.12.0 (https://github.com/interviewstreet/firepad-x/commit/03910ce475e04ddcab2e683877f579bfcbd32d91).
3856

3957
## v0.3.1 [#44](https://github.com/interviewstreet/firepad-x/pull/44)
4058

examples/firepad-monaco-example.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as monaco from "monaco-editor";
2-
import * as firebase from "firebase/app";
2+
import firebase from "firebase/app";
33
import "firebase/database";
44
import "firebase/firestore";
55

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@hackerrank/firepad",
33
"description": "Collaborative text editing powered by Firebase",
4-
"version": "0.7.4-beta",
4+
"version": "0.8.0-beta",
55
"author": {
66
"email": "[email protected]",
77
"name": "Progyan Bhattacharya",
@@ -54,7 +54,7 @@
5454
"node": ">= 10.17.0"
5555
},
5656
"peerDependencies": {
57-
"firebase": "7.12.0",
57+
"firebase": "8.10.1",
5858
"monaco-editor": "0.18.1"
5959
},
6060
"dependencies": {
@@ -73,7 +73,7 @@
7373
"child-process-promise": "2.2.1",
7474
"core-js": "3.11.0",
7575
"css-loader": "5.2.4",
76-
"firebase": "7.12.0",
76+
"firebase": "8.10.1",
7777
"git-format-staged": "2.1.1",
7878
"husky": "^7.0.0",
7979
"jest": "27.0.3",

src/firebase-adapter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import "firebase/database";
22

3-
import * as firebase from "firebase/app";
3+
import firebase from "firebase/app";
44

55
import { CursorType, ICursor } from "./cursor";
66
import {

src/firepad-classic.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as Firebase from "firebase";
1+
import firebase from "firebase";
22

33
import * as monaco from "monaco-editor";
44

@@ -50,7 +50,7 @@ export default class FirepadClassic implements IFirepad {
5050
* @param options - Firepad constructor options (optional).
5151
*/
5252
constructor(
53-
databaseRef: Firebase.database.Reference,
53+
databaseRef: firebase.database.Reference,
5454
editor: monaco.editor.IStandaloneCodeEditor,
5555
options: IFirepadClassicConstructorOptions = {}
5656
) {
@@ -224,7 +224,7 @@ export default class FirepadClassic implements IFirepad {
224224
* @param options - Firepad constructor options (optional).
225225
*/
226226
static fromMonaco(
227-
databaseRef: Firebase.database.Reference,
227+
databaseRef: firebase.database.Reference,
228228
editor: monaco.editor.IStandaloneCodeEditor,
229229
options?: IFirepadClassicConstructorOptions
230230
) {

src/firepad-monaco.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as monaco from "monaco-editor";
22
import { v4 as uuid } from "uuid";
3-
import * as firebase from "firebase/app";
3+
import firebase from "firebase/app";
44

55
import { IDatabaseAdapter, UserIDType } from "./database-adapter";
66
import { FirebaseAdapter } from "./firebase-adapter";

src/firestore-adapter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import "firebase/database";
22

3-
import * as firebase from "firebase/app";
3+
import firebase from "firebase/app";
44

55
import { CursorType, ICursor } from "./cursor";
66
import {

test/factory/database-adapter.factory.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as firebase from "firebase/app";
1+
import firebase from "firebase/app";
22
import { ICursor } from "../../src/cursor";
33
import {
44
DatabaseAdapterCallbackType,

test/firepad-monaco.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { editor } from "monaco-editor";
22
import { fromMonaco } from "../src/firepad-monaco";
33
import { getDatabaseAdapter, getEditorAdapter } from "./factory";
44
import { getMonacoEditor } from "./factory/monaco-editor.factory";
5-
import * as firebase from "firebase/app";
5+
import firebase from "firebase/app";
66

77
jest.mock("../src/firebase-adapter", () => {
88
const { getDatabaseAdapter } = require("./factory/database-adapter.factory");

0 commit comments

Comments
 (0)