feat: improve plugin options (#8)

* fix: improve plugin options

* fix: allow controlling wether coop headers are added or not

* docs: changeset minor

Author: h3rmanj

.changeset/itchy-moose-obey.md

@@ -0,0 +1,5 @@
+---
+"@intility/vite-plugin-msal": minor
+---
+
+allow `redirectBridgePath` to work with and without leading `/` and trailing `.html`

.changeset/loud-coats-wonder.md

@@ -0,0 +1,5 @@
+---
+"@intility/vite-plugin-msal": minor
+---
+
+allow controlling wether the dev and preview server emits COOP headers

.changeset/tender-falcons-stop.md

@@ -0,0 +1,5 @@
+---
+"@intility/vite-plugin-msal": minor
+---
+
+only fetch authority metadata if it is defined

README.md

@@ -22,15 +22,17 @@ export default defineConfig({
     msal({
       // optional - defaults to `/redirect`
       redirectBridgePath: "/redirect",
-      // optional - defaults to the common authority
-      // used to fetch authority metadata for the client during build
+      // optional - defaults to true
+      addCoopHeader: true,
+      // optional - defaults to undefined
+      // if defined: fetches authority metadata for the client during build
       authority: "https://login.microsoftonline.com/common"
     }),
   ]
 });
 ```
 
-Use the `withMetadata` function to enable the metadata resolution bypassing feature:
+Optional: Use the `withMetadata` function to enable the metadata resolution bypassing feature:
 
 ```ts
 import { withMetadata } from "@intility/vite-plugin-msal/client";

packages/vite-plugin-msal/src/index.ts

@@ -4,12 +4,13 @@ import { addBuildInput } from "./utils.js";
 
 type VitePluginMsalConfig = {
   redirectBridgePath: string;
-  authority: string;
+  authority?: string;
+  addCoopHeader: boolean;
 };
 
 const defaultConfig: VitePluginMsalConfig = {
-  redirectBridgePath: "/redirect",
-  authority: "https://login.microsoftonline.com/common",
+  redirectBridgePath: "redirect",
+  addCoopHeader: true,
 };
 
 async function fetchMsalMetadata(authority: string) {
@@ -71,9 +72,14 @@ function useCoopHeader(
   server: ViteDevServer | PreviewServer,
   config: VitePluginMsalConfig,
 ) {
+  if (!config.addCoopHeader) return;
+
   server.middlewares.use((req, res, next) => {
     const pathname = req.originalUrl?.split("?")[0];
-    if (pathname !== config.redirectBridgePath) {
+    if (
+      pathname !== config.redirectBridgePath &&
+      pathname !== `${config.redirectBridgePath}.html`
+    ) {
       res.setHeader("Cross-Origin-Opener-Policy", "same-origin");
     }
     next();
@@ -82,14 +88,18 @@ function useCoopHeader(
 
 export default function msal(config?: Partial<VitePluginMsalConfig>): Plugin {
   const mergedConfig = { ...defaultConfig, ...config };
+  // Normalize: ensure leading / and strip trailing .html
+  mergedConfig.redirectBridgePath = mergedConfig.redirectBridgePath
+    .replace(/\.html$/, "")
+    .replace(/^\/?/, "/");
   let resolvedId: string;
 
   return {
     name: "vite-plugin-msal",
 
     async config(userConfig) {
       const root = userConfig.root ?? process.cwd();
-      const htmlFileName = `${mergedConfig.redirectBridgePath.replace(/^\//, "")}.html`;
+      const htmlFileName = `${mergedConfig.redirectBridgePath.slice(1)}.html`;
       resolvedId = resolve(root, htmlFileName);
 
       addBuildInput(
@@ -99,24 +109,26 @@ export default function msal(config?: Partial<VitePluginMsalConfig>): Plugin {
         resolve(root, "index.html"),
       );
 
-      const { cloudDiscoveryMetadata, authorityMetadata } =
-        await fetchMsalMetadata(mergedConfig.authority);
+      if (mergedConfig.authority) {
+        const { cloudDiscoveryMetadata, authorityMetadata } =
+          await fetchMsalMetadata(mergedConfig.authority);
 
-      const define: Record<string, string> = {};
-      define.__VITE_PLUGIN_MSAL_METADATA_AUTHORITY__ = JSON.stringify(
-        mergedConfig.authority,
-      );
-      if (cloudDiscoveryMetadata) {
-        define.__VITE_PLUGIN_MSAL_CLOUD_DISCOVERY_METADATA__ = JSON.stringify(
-          cloudDiscoveryMetadata,
+        const define: Record<string, string> = {};
+        define.__VITE_PLUGIN_MSAL_METADATA_AUTHORITY__ = JSON.stringify(
+          mergedConfig.authority,
         );
-      }
-      if (authorityMetadata) {
-        define.__VITE_PLUGIN_MSAL_AUTHORITY_METADATA__ =
-          JSON.stringify(authorityMetadata);
-      }
+        if (cloudDiscoveryMetadata) {
+          define.__VITE_PLUGIN_MSAL_CLOUD_DISCOVERY_METADATA__ = JSON.stringify(
+            cloudDiscoveryMetadata,
+          );
+        }
+        if (authorityMetadata) {
+          define.__VITE_PLUGIN_MSAL_AUTHORITY_METADATA__ =
+            JSON.stringify(authorityMetadata);
+        }
 
-      return { define };
+        return { define };
+      }
     },
 
     resolveId(id) {
@@ -154,7 +166,11 @@ export default function msal(config?: Partial<VitePluginMsalConfig>): Plugin {
 
       server.middlewares.use((req, res, next) => {
         const pathname = req.originalUrl?.split("?")[0];
-        if (!req.originalUrl || pathname !== mergedConfig.redirectBridgePath) {
+        if (
+          !req.originalUrl ||
+          (pathname !== mergedConfig.redirectBridgePath &&
+            pathname !== `${mergedConfig.redirectBridgePath}.html`)
+        ) {
           return next();
         }