PR review changes

Author: omer-azmon

plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/AgentSourceFilesFetcher.java

@@ -89,27 +89,27 @@ private static String formatDirectoryList(Set<String> sourceDirectories) {
         }
 
         private AgentSourceFilesList buildSourceFilesList(String workspacePath, Set<String> sourceDirectories) {
-            // Populate search stack with source directories
-            final Stack<File> stack = new Stack<>();
+            // Populate search directory stack with source directories
+            final Stack<File> directoryStack = new Stack<>();
             sourceDirectories.stream()
                     .map(File::new)
                     .filter(f -> f.exists() && f.isDirectory())
-                    .forEach(stack::push);
+                    .forEach(directoryStack::push);
 
             // If no source directories are found in the workspace, use workspace root as search starting point
-            if (stack.isEmpty()) {
-                stack.push(new File(workspacePath));
+            if (directoryStack.isEmpty()) {
+                directoryStack.push(new File(workspacePath));
             }
 
             // Walk all directories and subdirectories and create a mapping for each file found
             ArrayList<String> sourceFilesList = new ArrayList<>();
-            while (!stack.empty() && stack.peek() != null) {
-                File f = stack.pop();
+            while (!directoryStack.empty() && directoryStack.peek() != null) {
+                File f = directoryStack.pop();
                 File[] fileList = f.listFiles();
                 if (fileList == null) continue;
-                for (File child : Objects.requireNonNull(f.listFiles())) {
+                for (File child : fileList) {
                     if (child.isDirectory()) {
-                        stack.push(child);
+                        directoryStack.push(child);
                     } else { // child.isFile()
                         sourceFilesList.add(child.getAbsolutePath());
                     }

plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/ModuleCoverageDataSourceFilesSet.java

@@ -8,7 +8,16 @@
 import java.util.Map;
 import java.util.Set;
 
+/**
+ * Collects and dispenses the set of source-files referenced in the coverage data.
+ */
 public class ModuleCoverageDataSourceFilesSet {
+
+    /**
+     * Build map by module of <code>ModuleCoverageDataSourceFilesSet</code>.
+     * @param rootNode the root node of the coverage data.
+     * @return
+     */
     public static Map<String, ModuleCoverageDataSourceFilesSet> constructModuleMap(Node rootNode) {
         Map<String, ModuleCoverageDataSourceFilesSet> moduleSourceFilesSetMap = new HashMap<>();
         for (Node child: rootNode.getChildren()) {