Merge pull request #148 from donwilson/patch-1

hlu2 · web-flow · commit f1b1db3171dc · 2018-05-25T18:33:24.000-07:00
Fix to soft boolean checks to properly disable logging
diff --git a/src/Diagnostics/LogRequestsToDisk.php b/src/Diagnostics/LogRequestsToDisk.php
@@ -30,7 +30,7 @@ class LogRequestsToDisk
      */
     public function __construct($enableServiceRequestLogging=false, $serviceRequestLoggingLocation=null)
     {
-        $this->EnableServiceRequestsLogging = $enableServiceRequestLogging;
+        $this->EnableServiceRequestsLogging = (!empty($enableServiceRequestLogging) && ("false" !== strtolower(trim($enableServiceRequestLogging))));
         $this->ServiceRequestLoggingLocation = $serviceRequestLoggingLocation;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class LogRequestsToDisk`
`30`	`30`	`*/`
`31`	`31`	`public function __construct($enableServiceRequestLogging=false, $serviceRequestLoggingLocation=null)`
`32`	`32`	`{`
`33`		`- $this->EnableServiceRequestsLogging = $enableServiceRequestLogging;`
	`33`	`+ $this->EnableServiceRequestsLogging = (!empty($enableServiceRequestLogging) && ("false" !== strtolower(trim($enableServiceRequestLogging))));`
`34`	`34`	`$this->ServiceRequestLoggingLocation = $serviceRequestLoggingLocation;`
`35`	`35`	`}`
`36`	`36`