form: added severity checks config

0einstein0 · 0einstein0 · commit ae52a28778a6 · 2025-03-14T15:13:41.000+01:00
diff --git a/invenio_app_rdm/config.py b/invenio_app_rdm/config.py
@@ -914,33 +914,6 @@ def github_link_render(record):
 
 APP_RDM_RECORDS_EXPORT_URL = "/records/<pid_value>/export/<export_format>"
 
-APP_RDM_DEPOSIT_FORM_SECTIONS_CONFIG = {
-    "files-section": ["files.enabled"],
-    "basic-information-section": [
-        "pids.doi",
-        "metadata.resource_type",
-        "metadata.title",
-        "metadata.additional_titles",
-        "metadata.publication_date",
-        "metadata.creators",
-        "metadata.description",
-        "metadata.additional_descriptions",
-        "metadata.rights",
-    ],
-    "recommended-information-section": [
-        "metadata.contributors",
-        "metadata.subjects",
-        "metadata.languages",
-        "metadata.dates",
-        "metadata.version",
-        "metadata.publisher",
-    ],
-    "funding-section": ["metadata.funding"],
-    "alternate-identifiers-section": ["metadata.identifiers"],
-    "related-works-section": ["metadata.related_identifiers"],
-    "visibility-section": ["access.embargo.until"],
-}
-
 APP_RDM_DEPOSIT_FORM_DEFAULTS = {
     "publication_date": lambda: datetime.now().strftime("%Y-%m-%d"),
     "rights": [
diff --git a/invenio_app_rdm/records_ui/views/deposits.py b/invenio_app_rdm/records_ui/views/deposits.py
@@ -359,7 +359,6 @@ def get_form_config(**kwargs):
         cf for cf in custom_fields["ui"] if not cf.get("hide_from_upload_form", False)
     ]
     quota = deepcopy(conf.get("APP_RDM_DEPOSIT_FORM_QUOTA", {}))
-    sections_config = deepcopy(conf.get("APP_RDM_DEPOSIT_FORM_SECTIONS_CONFIG", {}))
     record_quota = kwargs.pop("quota", None)
     if record_quota:
         quota["maxStorage"] = record_quota["quota_size"]
@@ -383,7 +382,6 @@ def get_form_config(**kwargs):
         ),
         user_communities_memberships=get_user_communities_memberships(),
         custom_fields=custom_fields,
-        sections_config=sections_config,
         publish_modal_extra=current_app.config.get(
             "APP_RDM_DEPOSIT_FORM_PUBLISH_MODAL_EXTRA"
         ),
diff --git a/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js b/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js
@@ -44,6 +44,7 @@ import { Card, Container, Grid, Ref, Sticky } from "semantic-ui-react";
 import PropTypes from "prop-types";
 import Overridable from "react-overridable";
 import { ShareDraftButton } from "./ShareDraftButton";
+import { depositFormSectionsConfig, severityChecksConfig } from "./config";
 
 export class RDMDepositForm extends Component {
   constructor(props) {
@@ -90,6 +91,9 @@ export class RDMDepositForm extends Component {
       this.noFiles = true;
     }
 
+    this.sectionsConfig = depositFormSectionsConfig;
+    this.severityChecks = severityChecksConfig;
+
     // hide community header for branded communities
     this.hide_community_selection = this.config.hide_community_selection || false;
   }
@@ -111,11 +115,11 @@ export class RDMDepositForm extends Component {
       allowEmptyFiles,
     } = this.props;
 
+    // Adding section id to custom fields UI, to be used for accordions
     const customFieldsUI = this.config.custom_fields.ui.map((section) => ({
       ...section,
       id: section.section.toLowerCase().replace(/\s+/g, "-") + "-section",
     }));
-    const sectionsConfig = this.config.sections_config;
 
     return (
       <Overridable
@@ -147,7 +151,7 @@ export class RDMDepositForm extends Component {
             <FormFeedback
               fieldPath="message"
               labels={this.config.custom_fields.error_labels}
-              sectionsConfig={sectionsConfig}
+              sectionsConfig={this.sectionsConfig}
             />
           </Overridable>
 
@@ -172,7 +176,8 @@ export class RDMDepositForm extends Component {
                   noFiles={this.noFiles}
                 >
                   <AccordionField
-                    includesPaths={sectionsConfig["files-section"]}
+                    includesPaths={this.sectionsConfig["files-section"]}
+                    severityChecks={this.severityChecks}
                     active
                     label={i18next.t("Files")}
                     id="files-section"
@@ -208,7 +213,8 @@ export class RDMDepositForm extends Component {
                   vocabularies={this.vocabularies}
                 >
                   <AccordionField
-                    includesPaths={sectionsConfig["basic-information-section"]}
+                    includesPaths={this.sectionsConfig["basic-information-section"]}
+                    severityChecks={this.severityChecks}
                     active
                     label={i18next.t("Basic information")}
                     id="basic-information-section"
@@ -366,7 +372,10 @@ export class RDMDepositForm extends Component {
                   record={record}
                 >
                   <AccordionField
-                    includesPaths={sectionsConfig["recommended-information-section"]}
+                    includesPaths={
+                      this.sectionsConfig["recommended-information-section"]
+                    }
+                    severityChecks={this.severityChecks}
                     label={i18next.t("Recommended information")}
                     id="recommended-information-section"
                   >
@@ -457,7 +466,8 @@ export class RDMDepositForm extends Component {
                   ui={this.accordionStyle}
                 >
                   <AccordionField
-                    includesPaths={sectionsConfig["funding-section"]}
+                    includesPaths={this.sectionsConfig["funding-section"]}
+                    severityChecks={this.severityChecks}
                     active
                     label="Funding"
                     ui={this.accordionStyle}
@@ -551,7 +561,8 @@ export class RDMDepositForm extends Component {
                   vocabularies={this.vocabularies}
                 >
                   <AccordionField
-                    includesPaths={sectionsConfig["alternate-identifiers-section"]}
+                    includesPaths={this.sectionsConfig["alternate-identifiers-section"]}
+                    severityChecks={this.severityChecks}
                     active
                     label={i18next.t("Alternate identifiers")}
                     id="alternate-identifiers-section"
@@ -577,7 +588,8 @@ export class RDMDepositForm extends Component {
                   vocabularies={this.vocabularies}
                 >
                   <AccordionField
-                    includesPaths={sectionsConfig["related-works-section"]}
+                    includesPaths={this.sectionsConfig["related-works-section"]}
+                    severityChecks={this.severityChecks}
                     active
                     label={i18next.t("Related works")}
                     id="related-works-section"
@@ -600,7 +612,8 @@ export class RDMDepositForm extends Component {
                   vocabularies={this.vocabularies}
                 >
                   <AccordionField
-                    includesPaths={sectionsConfig["references-section"]}
+                    includesPaths={this.sectionsConfig["references-section"]}
+                    severityChecks={this.severityChecks}
                     active
                     label={i18next.t("References")}
                     id="references-section"
diff --git a/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/config.js b/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/config.js
@@ -0,0 +1,48 @@
+// This file is part of InvenioRDM
+// Copyright (C) 2025 CERN.
+//
+// Invenio APP RDM is free software; you can redistribute it and/or modify it
+// under the terms of the MIT License; see LICENSE file for more details.
+import { i18next } from "@translations/invenio_app_rdm/i18next";
+
+const depositFormSectionsConfig = {
+  "files-section": ["files.enabled"],
+  "basic-information-section": [
+    "pids.doi",
+    "metadata.resource_type",
+    "metadata.title",
+    "metadata.additional_titles",
+    "metadata.publication_date",
+    "metadata.creators",
+    "metadata.description",
+    "metadata.additional_descriptions",
+    "metadata.rights",
+  ],
+  "recommended-information-section": [
+    "metadata.contributors",
+    "metadata.subjects",
+    "metadata.languages",
+    "metadata.dates",
+    "metadata.version",
+    "metadata.publisher",
+  ],
+  "funding-section": ["metadata.funding"],
+  "alternate-identifiers-section": ["metadata.identifiers"],
+  "related-works-section": ["metadata.related_identifiers"],
+  "visibility-section": ["access.files", "access.embargo.until"],
+};
+
+const severityChecksConfig = {
+  info: {
+    label: i18next.t("Recommended"),
+    description: i18next.t("This check is recommended but not mandatory."),
+  },
+  error: {
+    label: i18next.t("Error"),
+    description: i18next.t(
+      "This check indicates a critical issue that must be addressed."
+    ),
+  },
+};
+
+export { depositFormSectionsConfig, severityChecksConfig };
