Skip to content

Commit ca953cf

Browse files
committed
use namespace for globally accessed variables
1 parent fdf64f8 commit ca953cf

File tree

1 file changed

+8
-9
lines changed
  • invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records

1 file changed

+8
-9
lines changed

invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/detail.html

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,8 @@
2626
{%- set title = record_ui["metadata"]["title"] %}
2727
{%- set metadata = record_ui["metadata"] %}
2828

29-
{%- if record_ui["files"]["enabled"] and permissions.can_read_files %}
30-
{%- set files = files | order_entries | selectattr("status", "==", "completed") | list %}
31-
{%- else %}
32-
{%- set files = [] %}
33-
{%- endif %}
29+
<!-- Shared namespace for files to allow overridability on child blocks while maintaining reference to parent values -->
30+
{% set files_ns = namespace(preview_file=None, files=[]) %}
3431

3532
{%- set can_curate_record = permissions is defined and (permissions.can_edit or permissions.can_review) %}
3633

@@ -294,16 +291,18 @@
294291
aria-label="{{ _('Files') }}">
295292
{%- if permissions.can_read_files -%}
296293
{# record has files AND user can see files #}
297-
{%- if files|length > 0 -%}
294+
{# Shared namespace for files (outside blocks) #}
295+
{%- set files_ns.files = files | order_entries | selectattr("status", "==", "completed") | list %}
296+
{%- if files_ns.files|length > 0 -%}
298297
<h2 id="files-heading">{{ _('Files') }}</h2>
299-
{%- if files|has_previewable_files -%}
298+
{%- if files_ns.files|has_previewable_files -%}
299+
{%-set files_ns.preview_file = files_ns.files|select_preview_file(default_preview=record_ui["files"]["default_preview"]) %}
300300
{%- block record_file_preview -%}
301-
{%-set preview_file = files|select_preview_file(default_preview=record_ui["files"]["default_preview"]) %}
302301
{{ preview_file_box(preview_file, record_ui["id"], is_preview, record, include_deleted) }}
303302
{%- endblock record_file_preview -%}
304303
{%- endif -%}
305304
{%- block record_file_list -%}
306-
{{ file_list_box(files, record_ui["id"], is_preview, include_deleted, record, permissions) }}
305+
{{ file_list_box(files_ns.files, record_ui["id"], is_preview, include_deleted, record, permissions) }}
307306
{%- endblock record_file_list -%}
308307
{% endif %}
309308
{% else %}

0 commit comments

Comments
 (0)