fix: file not possible to delete if it fails between operations

* if file upload fails for example on commit, it is not possible to
* remove it from the UI by clicking on trash can

Author: Ducica

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/api/DepositFilesService.js

@@ -53,6 +53,9 @@ export class UploadProgressNotifier {
   onUploadAdded(filename) {
     throw new Error("Not implemented.");
   }
+  onUploadInitialized(filename, links) {
+    throw new Error("Not implemented.");
+  }
   onUploadStarted(filename, cancelFunc) {
     throw new Error("Not implemented.");
   }
@@ -165,6 +168,10 @@ export class RDMDepositFilesService extends DepositFilesService {
     let initializedFileMetadata;
     try {
       initializedFileMetadata = await this._initializeUpload(initializeUploadURL, file);
+      this.progressNotifier.onUploadInitialized(
+        file.name,
+        initializedFileMetadata.links
+      );
     } catch (error) {
       this._onError(file);
       return;

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/components/UploadProgressNotifier/UploadProgressNotifier.js

@@ -11,6 +11,7 @@ import {
   FILE_UPLOAD_CANCELLED,
   FILE_UPLOAD_FAILED,
   FILE_UPLOAD_FINISHED,
+  FILE_UPLOAD_INITIALIZED,
   FILE_UPLOAD_IN_PROGRESS,
   FILE_UPLOAD_SET_CANCEL_FUNCTION,
 } from "../../state/types";
@@ -26,6 +27,17 @@ export class RDMUploadProgressNotifier extends UploadProgressNotifier {
       });
   }
 
+  onUploadInitialized(filename, links) {
+    this.dispatcher &&
+      this.dispatcher({
+        type: FILE_UPLOAD_INITIALIZED,
+        payload: {
+          filename: filename,
+          links: links,
+        },
+      });
+  }
+
   onUploadStarted(filename, cancelFn) {
     this.dispatcher &&
       this.dispatcher({

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/state/actions/files.js

@@ -17,6 +17,7 @@ import {
   FILE_UPLOAD_ADDED,
   FILE_UPLOAD_FINISHED,
   FILE_UPLOAD_FAILED,
+  FILE_UPLOAD_INITIALIZED,
 } from "../types";
 import { saveDraftWithUrlUpdate } from "./deposit";
 
@@ -82,7 +83,18 @@ export const initializeFileUpload = (draft, file) => {
           filename: file.name,
         },
       });
-      return await config.service.files.initializeUpload(draft.links.files, file);
+      const response = await config.service.files.initializeUpload(
+        draft.links.files,
+        file
+      );
+      dispatch({
+        type: FILE_UPLOAD_INITIALIZED,
+        payload: {
+          filename: file.name,
+          links: response.links,
+        },
+      });
+      return response;
     } catch (error) {
       const axiosError = error?.t0 && error.t0.isAxiosError ? error.t0 : error;
 

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/state/reducers/files.js

@@ -15,6 +15,7 @@ import {
   FILE_UPLOAD_CANCELLED,
   FILE_UPLOAD_FAILED,
   FILE_UPLOAD_FINISHED,
+  FILE_UPLOAD_INITIALIZED,
   FILE_UPLOAD_IN_PROGRESS,
   FILE_UPLOAD_SAVE_DRAFT_FAILED,
   FILE_UPLOAD_SET_CANCEL_FUNCTION,
@@ -53,6 +54,18 @@ const fileReducer = (state = initialState, action) => {
         },
         actionState: action.type,
       };
+    case FILE_UPLOAD_INITIALIZED:
+      return {
+        ...state,
+        entries: {
+          ...state.entries,
+          [remoteFileName]: {
+            ...state.entries[remoteFileName],
+            links: action.payload.links,
+          },
+        },
+        actionState: action.type,
+      };
     case FILE_UPLOAD_IN_PROGRESS:
       return {
         ...state,

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/state/types/index.js

@@ -48,6 +48,7 @@ export const SET_DOI_NEEDED = "SET_DOI_NEEDED";
 
 // Files
 export const FILE_UPLOAD_ADDED = "FILE_UPLOAD_ADDED";
+export const FILE_UPLOAD_INITIALIZED = "FILE_UPLOAD_INITIALIZED";
 export const FILE_UPLOAD_IN_PROGRESS = "FILE_UPLOAD_IN_PROGRESS";
 export const FILE_UPLOAD_FINISHED = "FILE_UPLOAD_FINISHED";
 export const FILE_UPLOAD_FAILED = "FILE_UPLOAD_FAILED";