-
Notifications
You must be signed in to change notification settings - Fork 59
Open
Description
Package version (if known): 2.1.6
Does webpack.py need to include peer dependencies of the packages it uses? react-invenio-forms relies on the following packages, as listed in its peer dependencies:
"@ckeditor/ckeditor5-build-classic": "^16.0.0",
"@ckeditor/ckeditor5-react": "^2.1.0",
"formik": "^2.1.0",
invenio-app-rdm lists them in its webpack.py: https://github.com/inveniosoftware/invenio-app-rdm/blob/87148c6531eac48b28a3cee515c75e759e9dd25b/invenio_app_rdm/theme/webpack.py#L34-L36
Should they in fact be listed in here instead? Otherwise consumers of invenio-search-ui need to list them in their webpacks, but this doesn't appear to documented anywhere.
Metadata
Metadata
Assignees
Labels
No labels