Merge pull request #1565 from inversify/chore/update-inversify-package-to-be-esm-only

notaphplover · web-flow · commit 7be37932e496 · 2026-02-21T09:37:22.000+01:00
Update inversify package to be esm only
diff --git a/.changeset/calm-rivers-arrive.md b/.changeset/calm-rivers-arrive.md
@@ -0,0 +1,5 @@
+---
+"inversify": major
+---
+
+- Updated package to be ESM only
diff --git a/.github/renovate.json b/.github/renovate.json
@@ -46,6 +46,12 @@
       "groupName": "GitHub Actions",
       "matchManagers": ["github-actions"]
     },
+    {
+      "description": "Updates for uWebSockets.js",
+      "matchDatasources": ["github-tags", "github-releases"],
+      "matchPackageNames": ["uNetworking/uWebSockets.js"],
+      "versioning": "semver-coerced"
+    },
     {
       "description": "Quarantine packages with current known issues",
       "enabled": false,
diff --git a/packages/container/libraries/inversify/.gitignore b/packages/container/libraries/inversify/.gitignore
@@ -2,7 +2,6 @@
 /lib/**
 
 /tsconfig.tsbuildinfo
-/tsconfig.cjs.tsbuildinfo
 /tsconfig.esm.tsbuildinfo
 
 # Test coverage report
diff --git a/packages/container/libraries/inversify/.npmignore b/packages/container/libraries/inversify/.npmignore
@@ -4,24 +4,22 @@
 /docs
 /reports
 
+**/*.ts
 **/*.spec.js
 **/*.spec.js.map
-**/*.ts
-!lib/cjs/**/*.d.ts
-lib/esm/**/*.d.ts.map
-!lib/esm/index.d.ts
-!lib/esm/index.d.ts.map
+**/*.spec.d.ts.map
+**/*.spec-d.js
+**/*.spec-d.js.map
+**/*.spec-d.d.ts.map
+!lib/**/*.d.ts
 
 .lintstagedrc.json
 eslint.config.mjs
 vitest.config.mjs
 vitest.config.stryker.mjs
 vitest.workspace.mjs
 prettier.config.mjs
-rollup.config.mjs
 stryker.config.mjs
-tsconfig.cjs.json
-tsconfig.cjs.tsbuildinfo
 tsconfig.esm.json
 tsconfig.esm.tsbuildinfo
 tsconfig.json
diff --git a/packages/container/libraries/inversify/eslint.config.mjs b/packages/container/libraries/inversify/eslint.config.mjs
@@ -1,3 +1,23 @@
 import { buildDefaultConfig } from '@inversifyjs/foundation-eslint-config';
 
-export default [...buildDefaultConfig()];
+import plugin from '@inversifyjs/eslint-plugin-require-extensions';
+
+export default [
+  ...buildDefaultConfig(
+    {
+      '@typescript-eslint/consistent-type-imports': [
+        'error',
+        {
+          disallowTypeAnnotations: true,
+          fixStyle: 'inline-type-imports',
+          prefer: 'type-imports',
+        },
+      ],
+      'require-extensions/require-extensions': 'error',
+      'require-extensions/require-index': 'error',
+    },
+    {
+      'require-extensions': plugin,
+    },
+  ),
+];
diff --git a/packages/container/libraries/inversify/package.json b/packages/container/libraries/inversify/package.json
@@ -10,14 +10,13 @@
     "@inversifyjs/core": "workspace:*"
   },
   "devDependencies": {
+    "@inversifyjs/eslint-plugin-require-extensions": "workspace:*",
     "@types/node": "24.10.13",
     "@vitest/coverage-v8": "4.0.18",
     "eslint": "9.39.2",
     "prettier": "3.8.1",
     "reflect-metadata": "0.2.2",
     "rimraf": "6.1.3",
-    "rollup": "4.57.1",
-    "ts-loader": "9.5.4",
     "tslib": "2.8.1",
     "typescript": "5.9.3",
     "vitest": "4.0.18"
@@ -38,14 +37,10 @@
     "pnpm": "^10.13.1"
   },
   "license": "MIT",
-  "main": "lib/cjs/index.js",
-  "module": "lib/esm/index.js",
   "exports": {
-    ".": {
-      "import": "./lib/esm/index.js",
-      "require": "./lib/cjs/index.js"
-    }
+    ".": "./lib/index.js"
   },
+  "type": "module",
   "name": "inversify",
   "publishConfig": {
     "access": "public"
@@ -55,9 +50,7 @@
     "url": "git+https://github.com/inversify/monorepo.git"
   },
   "scripts": {
-    "build": "pnpm run build:cjs && pnpm run build:esm",
-    "build:cjs": "tsc --build tsconfig.cjs.json && pnpm exec foundation-ts-package-cjs ./lib/cjs",
-    "build:esm": "rollup -c ./rollup.config.mjs && pnpm exec foundation-ts-package-esm ./lib/esm",
+    "build": "tsc",
     "build:clean": "rimraf lib",
     "format": "prettier --write ./src",
     "lint": "eslint ./src",
diff --git a/packages/container/libraries/inversify/rollup.config.mjs b/packages/container/libraries/inversify/rollup.config.mjs
diff --git a/packages/container/libraries/inversify/src/test/annotation/inject.int.spec.ts b/packages/container/libraries/inversify/src/test/annotation/inject.int.spec.ts
@@ -4,8 +4,8 @@ import {
   decorate,
   inject,
   LazyServiceIdentifier,
-  ServiceIdentifier,
-} from '../..';
+  type ServiceIdentifier,
+} from '../../index.js';
 
 class Katana {}
 class Shuriken {}
diff --git a/packages/container/libraries/inversify/src/test/annotation/injectable.int.spec.ts b/packages/container/libraries/inversify/src/test/annotation/injectable.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { decorate, injectable } from '../..';
+import { decorate, injectable } from '../../index.js';
 
 describe(injectable, () => {
   it('Should throw when applied multiple times', () => {
diff --git a/packages/container/libraries/inversify/src/test/annotation/multi_inject.int.spec.ts b/packages/container/libraries/inversify/src/test/annotation/multi_inject.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { decorate, multiInject } from '../..';
+import { decorate, multiInject } from '../../index.js';
 
 type Weapon = object;
 
diff --git a/packages/container/libraries/inversify/src/test/annotation/named.int.spec.ts b/packages/container/libraries/inversify/src/test/annotation/named.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { decorate, named } from '../..';
+import { decorate, named } from '../../index.js';
 
 type Weapon = unknown;
 
diff --git a/packages/container/libraries/inversify/src/test/annotation/optional.int.spec.ts b/packages/container/libraries/inversify/src/test/annotation/optional.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable, optional } from '../..';
+import { Container, inject, injectable, optional } from '../../index.js';
 
 describe(optional, () => {
   it('Should allow to flag dependencies as optional', () => {
diff --git a/packages/container/libraries/inversify/src/test/annotation/post_construct.int.spec.ts b/packages/container/libraries/inversify/src/test/annotation/post_construct.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { postConstruct } from '../..';
+import { postConstruct } from '../../index.js';
 
 describe('@postConstruct', () => {
   it('Should throw when applied multiple times', () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/bugs.int.spec.ts b/packages/container/libraries/inversify/src/test/bugs/bugs.int.spec.ts
@@ -12,7 +12,7 @@ import {
   ServiceIdentifier,
   tagged,
   unmanaged,
-} from '../..';
+} from '../../index.js';
 
 describe('Bugs', () => {
   it('Should not throw when args length of base and derived class match (property setter)', () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_1190.test.ts b/packages/container/libraries/inversify/src/test/bugs/issue_1190.test.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable, named, optional } from '../../index';
+import { Container, inject, injectable, named, optional } from '../../index.js';
 
 describe('Issue 1190', () => {
   it('should inject a katana as default weapon to ninja', () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_1416.test.ts b/packages/container/libraries/inversify/src/test/bugs/issue_1416.test.ts
@@ -1,6 +1,11 @@
 import { describe, expect, it, Mock, vitest } from 'vitest';
 
-import { bindingScopeValues, Container, injectable, preDestroy } from '../..';
+import {
+  bindingScopeValues,
+  Container,
+  injectable,
+  preDestroy,
+} from '../../index.js';
 
 describe('Issue 1416', () => {
   it('should allow providing default values on optional bindings', async () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_1515.test.ts b/packages/container/libraries/inversify/src/test/bugs/issue_1515.test.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable, multiInject } from '../..';
+import { Container, inject, injectable, multiInject } from '../../index.js';
 
 describe('Issue 1515', () => {
   it('should properly throw on circular dependency', () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_1518.test.ts b/packages/container/libraries/inversify/src/test/bugs/issue_1518.test.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container } from '../..';
+import { Container } from '../../index.js';
 
 describe('Issue 1518', () => {
   it('should not throw on deactivating undefined singleton values', async () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_1564.int.spec.ts b/packages/container/libraries/inversify/src/test/bugs/issue_1564.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable } from '../..';
+import { Container, inject, injectable } from '../../index.js';
 
 describe('Issue 1564', () => {
   it('should not throw on getting async services bound using "toService"', async () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_543.int.spec.ts b/packages/container/libraries/inversify/src/test/bugs/issue_543.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable } from '../../index';
+import { Container, inject, injectable } from '../../index.js';
 
 describe('Issue 543', () => {
   it('Should throw correct circular dependency path', () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_549.int.spec.ts b/packages/container/libraries/inversify/src/test/bugs/issue_549.int.spec.ts
@@ -12,7 +12,7 @@ import {
   injectable,
   ResolutionContext,
   ServiceIdentifier,
-} from '../..';
+} from '../../index.js';
 
 describe('Issue 549', () => {
   describe('having a circular dependency', () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_706.test.ts b/packages/container/libraries/inversify/src/test/bugs/issue_706.test.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { bindingScopeValues, Container, injectable } from '../..';
+import { bindingScopeValues, Container, injectable } from '../../index.js';
 
 describe('Issue 706', () => {
   it('Should expose BindingScopeEnum as part of the public API', () => {
diff --git a/packages/container/libraries/inversify/src/test/bugs/issue_928.test.ts b/packages/container/libraries/inversify/src/test/bugs/issue_928.test.ts
@@ -1,6 +1,12 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable, Newable, optional } from '../..';
+import {
+  Container,
+  inject,
+  injectable,
+  Newable,
+  optional,
+} from '../../index.js';
 
 describe('Issue 928', () => {
   it('should inject the right instances', () => {
diff --git a/packages/container/libraries/inversify/src/test/container/container.int.spec.ts b/packages/container/libraries/inversify/src/test/container/container.int.spec.ts
@@ -7,7 +7,7 @@ import {
   injectable,
   postConstruct,
   ResolutionContext,
-} from '../..';
+} from '../../index.js';
 
 describe(Container, () => {
   it('Should unbindAsync a binding when requested', async () => {
diff --git a/packages/container/libraries/inversify/src/test/container/container_module.int.spec.ts b/packages/container/libraries/inversify/src/test/container/container_module.int.spec.ts
@@ -1,11 +1,11 @@
-import { describe, expect, expectTypeOf, it, Mock, vitest } from 'vitest';
+import { describe, expect, expectTypeOf, it, type Mock, vitest } from 'vitest';
 
 import {
   Container,
   ContainerModule,
-  ContainerModuleLoadOptions,
-  ResolutionContext,
-} from '../..';
+  type ContainerModuleLoadOptions,
+  type ResolutionContext,
+} from '../../index.js';
 
 describe(ContainerModule, () => {
   it('Should be able to set the registry of a container module', () => {
diff --git a/packages/container/libraries/inversify/src/test/features/named_default.int.spec.ts b/packages/container/libraries/inversify/src/test/features/named_default.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable, named } from '../..';
+import { Container, inject, injectable, named } from '../../index.js';
 
 describe('Named default', () => {
   it('Should be able to inject a default to avoid ambiguous binding exceptions', () => {
diff --git a/packages/container/libraries/inversify/src/test/features/property_injection.int.spec.ts b/packages/container/libraries/inversify/src/test/features/property_injection.int.spec.ts
@@ -10,7 +10,7 @@ import {
   optional,
   tagged,
   unmanaged,
-} from '../..';
+} from '../../index.js';
 
 describe('Property Injection', () => {
   it('Should be able to inject a property', () => {
diff --git a/packages/container/libraries/inversify/src/test/features/request_scope.int.spec.ts b/packages/container/libraries/inversify/src/test/features/request_scope.int.spec.ts
@@ -2,7 +2,7 @@ import { describe, expect, it } from 'vitest';
 
 import { performance } from 'node:perf_hooks';
 
-import { Container, inject, injectable, named } from '../..';
+import { Container, inject, injectable, named } from '../../index.js';
 
 describe('inRequestScope', () => {
   it('Should support request scope in basic bindings', () => {
diff --git a/packages/container/libraries/inversify/src/test/features/transitive_bindings.int.spec.ts b/packages/container/libraries/inversify/src/test/features/transitive_bindings.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, injectable } from '../..';
+import { Container, injectable } from '../../index.js';
 
 describe('Transitive bindings', () => {
   it('Should be able to bind to a service', () => {
diff --git a/packages/container/libraries/inversify/src/test/inversify.int.spec.ts b/packages/container/libraries/inversify/src/test/inversify.int.spec.ts
@@ -15,7 +15,7 @@ import {
   Newable,
   ResolutionContext,
   tagged,
-} from '..';
+} from '../index.js';
 
 describe('InversifyJS', () => {
   it('Should be able to resolve and inject dependencies', () => {
diff --git a/packages/container/libraries/inversify/src/test/node/error_messages.int.spec.ts b/packages/container/libraries/inversify/src/test/node/error_messages.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, injectable } from '../..';
+import { Container, injectable } from '../../index.js';
 
 describe('Error message when resolving fails', () => {
   @injectable()
diff --git a/packages/container/libraries/inversify/src/test/node/exceptions.int.spec.ts b/packages/container/libraries/inversify/src/test/node/exceptions.int.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable } from '../..';
+import { Container, inject, injectable } from '../../index.js';
 
 describe('Node', () => {
   it('Should throw if circular dependencies found', () => {
diff --git a/packages/container/libraries/inversify/src/test/node/proxies.int.spec.ts b/packages/container/libraries/inversify/src/test/node/proxies.int.spec.ts
@@ -1,6 +1,11 @@
 import { describe, expect, it } from 'vitest';
 
-import { Container, inject, injectable, ResolutionContext } from '../..';
+import {
+  Container,
+  inject,
+  injectable,
+  ResolutionContext,
+} from '../../index.js';
 
 describe('InversifyJS', () => {
   it('Should support the injection of proxied objects', () => {
diff --git a/packages/container/libraries/inversify/tsconfig.cjs.json b/packages/container/libraries/inversify/tsconfig.cjs.json
diff --git a/packages/container/libraries/inversify/tsconfig.esm.json b/packages/container/libraries/inversify/tsconfig.esm.json
@@ -3,7 +3,7 @@
   "extends": "@inversifyjs/foundation-typescript-config/tsconfig.base.esm.json",
   "compilerOptions": {
     "emitDecoratorMetadata": true,
-    "outDir": "./lib/esm",
+    "outDir": "./lib",
     "rootDir": "./src",
     "tsBuildInfoFile": "tsconfig.esm.tsbuildinfo"
   },
diff --git a/packages/container/libraries/inversify/tsconfig.json b/packages/container/libraries/inversify/tsconfig.json
@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tsconfig",
-  "extends": "./tsconfig.cjs.json"
+  "extends": "./tsconfig.esm.json"
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"inversify": major
 +---
++
 +- Updated package to be ESM only