Skip to content

Extend Sign in with Apple OAuth Provider - add ability to set full name #7603

Open
@mikehardy

Description

@mikehardy

With release 10.7.0 of firebase-ios-sdk the auth module gained the ability to set the full name for sign in with apple: https://firebase.google.com/support/release-notes/ios#authentication_7

The OAuth provider likely needs an extension to accept the new parameter (hopefully optional...at least at the javascript layer here) and then call the new API signature in the underlying firebase-ios-sdk

Likely location to add new parameter for the full name in the Apple OAuth credential creation:

static credential(token, secret) {
return {
token,
secret,
providerId,
};

Likely location to swap out the current more generic OAuthProvider call for the apple-specific one mentioned here firebase/firebase-ios-sdk#4393 (comment):

credential = [FIROAuthProvider credentialWithProviderID:provider
IDToken:authToken
rawNonce:authTokenSecret];

PRs welcome! Confirmed that it is tested and working locally critical...

As mentioned in #4046

Metadata

Metadata

Assignees

No one assigned

    Labels

    Keep Openavoids the stale bothelp: good-first-issueIssues that are non-critical issues & well defined for first time contributors.help: needs-triageIssue needs additional investigation/triaging.type: enhancementImplements a new Feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions