🚀 [firestore] Allow single filter in `and()` `or()` queries.

[ycmjason]

Firstly, thank you so much for working on this library. My apps are not possible without you guys! 🙇‍♀️ Big ❤️ guys!

What feature would you like to see?

In my apps, there are some occasions where the queries within and() / or() changes based on conditions. For example

    query(
      userCollection,
      and(
        where('happy', '>', 10),
        ...(minSadness !== undefined ? [where('sadness', '>', minSadness)] : []),
      ),
    ),

Currently the API wouldn't support this usecase as it will throw:

https://github.com/invertase/react-native-firebase/blob/main/packages/firestore/lib/FirestoreFilter.js#L45-L47

I do have a work around by wrapping the and function:

import {  and as firestoreAnd } from '@react-native-firebase/firestore';

const and: typeof firestoreAnd = (...queries) => {
  if (queries.length === 1) return queries[0];
  return firestoreAnd(...queries);
};

Ideally this library would supprot this?

P.S. I haven't checked, but I have the impression that this is supported in the official web modular api. (not 100% sure... don't quote me on that xD)

[mikehardy]

Hi there -

P.S. I haven't checked, but I have the impression that this is supported in the official web modular api. (not 100% sure... don't quote me on that xD)

That is the critical bit of information though - and we'll need to quote you on it ;-) - if firebase-js-sdk doesn't support it, we will not support it. If they do, we should. Can you test with firebase-js-sdk and report back? Thanks

[ycmjason]

Alright alright you caught me. I was being lazy. I will go ahead and check! I will report back soon!

[ycmjason]

@mikehardy here you go. I have verified or would accept 1 query. and should follow the same pattern:

https://bolt.new/~/bolt-vanilla-vite-nfynxhn4

[mikehardy]

Nice use of bolt - and yes, a quick edit from or to and shows it appears to work as well

Seems we have a feature gap here between firebase-js-sdk and our API, we should be able to fix that

[ycmjason]

@mikehardy can't believe my first use of bolt is with bug reporting ahhaha. but ya it is quite handy for bug reproduction!