Skip to content

Commit b3064ab

Browse files
Fix issue with php service sub dicts copying into php-base (#659)
An example of an issue with this is AUTOSTART_PHP_FPM in php-fpm environment occasionally appearing in other pods depending on the non-deterministic order of resource rendering
1 parent 078aa75 commit b3064ab

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

harness/attributes/docker.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ attributes:
2828
APP_DATABASE_PASSWORD: = @('database.pass')
2929
APP_SECRET: = @('akeneo.secret')
3030
job-queue-consumer:
31+
extends:
32+
- php-base
3133
enabled: "= 'job-queue-consumer' in @('app.services')"
3234
image: = @('docker.repository') ~ ':' ~ @('app.version') ~ '-job-queue-consumer'
3335
publish: = @('services.job-queue-consumer.enabled')

helm/app/templates/application/job-queue-consumer/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- with mergeOverwrite (dict) (index .Values.services "php-base") (index .Values.services "job-queue-consumer") -}}
1+
{{- with (include "service.resolved" (dict "root" $ "service_name" "job-queue-consumer") | fromYaml) -}}
22
{{- if .enabled }}
33
apiVersion: apps/v1
44
kind: Deployment
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
{{- $service := mergeOverwrite (dict) (index .Values.services "php-base") (index .Values.services "job-queue-consumer") -}}
1+
{{- $service := include "service.resolved" (dict "root" $ "service_name" "job-queue-consumer") | fromYaml -}}
22
{{ template "service.environment.secret" (dict "service_name" "job-queue-consumer" "service" $service "root" $) }}

0 commit comments

Comments
 (0)