Update to gobl 300#28
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the project to use GOBL version 0.300.2, which introduces changes to tax structure and API. The update modifies how taxes are represented in invoices, particularly replacing the rate field with separate key and rate fields for better tax categorization.
- Updated GOBL dependency from v0.214.1 to v0.300.2
- Modified tax structure throughout test data files to use separate
keyandratefields - Updated code references to use new tax constants and extension keys
- Added documentation badge to README
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated GOBL dependency and other package versions |
| test/data/*.json | Updated tax structures to use new key and rate field format |
| doc/lines_test.go | Updated tax rate constant reference |
| doc/breakdown_test.go | Updated tax constants and extension key references |
| doc/breakdown.go | Updated extension key references |
| README.md | Added DeepWiki documentation badge |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| "rate": "reduced", | ||
| "percent": "9.0%", | ||
| "ext": { | ||
| "es-tbai-exemption": "RL", |
There was a problem hiding this comment.
Why the rate reduced is getting an exemption code?
There was a problem hiding this comment.
There are other cases like this in the other json files. Please, review. It might be a bug in the GOBL addon.
| &tax.Combo{ | ||
| Category: tax.CategoryVAT, | ||
| Rate: tax.RateExempt, | ||
| Rate: tax.KeyExport, |
There was a problem hiding this comment.
Shouldn't this set the Key instead of the Rate which is now reserved for general, reduced, intermediate…
| Category: tax.CategoryVAT, | ||
| Rate: tax.RateExempt, | ||
| Ext: tax.Extensions{tbai.ExtKeyExemption: "E1"}, | ||
| Rate: tax.KeyExempt, |
There was a problem hiding this comment.
Shouldn't this set the Key instead of the Rate which is now reserved for general, reduced, intermediate…
|
This PR is replaced by this one: #30 |
No description provided.