Fix customer without ID, upgrade to GOBL 0.304#30
Merged
Conversation
samlown
commented
Dec 19, 2025
samlown
commented
Contributor
- Will not try to insert customers if there is no tax ID nor identity.
- Upgrades to 0.304, which had a load of changes for the new keys, services, and goods.
Contributor
Author
|
This one replaces #28 |
Closed
pmenendz
approved these changes
Dec 19, 2025
pmenendz
left a comment
pmenendz
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but shouldn't this validation be in the addon?
cavalle
approved these changes
Dec 19, 2025
cavalle
left a comment
cavalle
left a comment
Contributor
There was a problem hiding this comment.
Agreed with this change (assuming the TicketBAI format allows it). And in any case, If TBAI wouldn't allow it, this should be better validated in the addon not here. So, either case, the change makes sense to me.
Contributor
|
I hadn't seen Pablo's review before mine. I guess " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.