Skip to content

[Bug] iOS showNavigationButtons prop is not being set #49

Open
@thernando-payworks

Description

@thernando-payworks

Description
When setting the WebViewOptions prop showNavigationButtons to false in iOS, the navigation buttons are still shown in the toolbar. In Android, the navigation buttons are properly hidden.

Potential Fix
The value for showNavigationsButtons is passed but never assigned in the iOS WebViewOptions. Assigning the value in this block solves the issue.

extension OSInAppBrowserWebViewModel {
func toWebViewOptions() -> OSIABWebViewOptions {
OSIABWebViewOptions(
showURL: self.showURL,
showToolbar: self.showToolbar,
clearCache: self.clearCache,
clearSessionCache: self.clearSessionCache,
mediaPlaybackRequiresUserAction: self.mediaPlaybackRequiresUserAction,
closeButtonText: self.closeButtonText,
toolbarPosition: self.toolbarPosition,
leftToRight: self.leftToRight,
allowOverScroll: self.iOS.allowOverScroll,
enableViewportScale: self.iOS.enableViewportScale,
allowInLineMediaPlayback: self.iOS.allowInLineMediaPlayback,
surpressIncrementalRendering: self.iOS.surpressIncrementalRendering,
viewStyle: self.iOS.viewStyle,
animationEffect: self.iOS.animationEffect,
customUserAgent: self.customWebViewUserAgent
)
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions