[Android] Geolocation - Custom setInterval and setFastestInterval

[tripodsgames]

Feature Request

Plugin

Geolocation

Description

Add an option to set a custom Interval and FastestInterval.

capacitor-plugins/geolocation/android/src/main/java/com/capacitorjs/plugins/geolocation/Geolocation.java

Line 52 in 561fea2

locationRequest.setInterval(10000);

capacitor-plugins/geolocation/android/src/main/java/com/capacitorjs/plugins/geolocation/Geolocation.java

Line 53 in 561fea2

locationRequest.setFastestInterval(5000);

UPDATE

See #538 (comment)

Platform(s)

Android

Preferred Solution

Add the options interval and fastestInterval in the PositionOptions interface.

[szundi]

Hello @Ionitron !

I think this should be handled as a bug, please consider the following reasoning.

Capacitor should provide one unified codebase for different platforms. With this code that is now in the Geolocation plugin here and there, Android now gives positions every 5 seconds instead of 1 seconds if it is specified in the timeout parameter. Web and iOS works well with the same user code and producing the desired output based on the API definition: positions every second.

I think according to the meaning of the "timeout" parameter, the code up there should not use 10000 and 5000 as constants, but the timeout parameter values for setInterval and setFastestInterval too - the only way it makes sure the app works according to the API on all platforms, including Android. This is the result of the simpler API of this only "timeout" parameter.

Do you think the API "timeout" parameter actually means the requested position period?

Thanks for considering, Capacitor is awesome.

András

[szundi]

I can indeed confirm that when I change the 10000 and 5000 to the "timeout" variable value (1000 in my case), it works as specified in the Capacitor API, and the coordinates are refreshed at the correct period.

It is therefore seems to be a good solution to fix this bug, also it confirms that using these literals in the Android specific code are completely ignores the fact that there is this timeout parameter and this is the direct cause of the bug.

If you accept to change this like above, I can try to file a PR. This will be my first to contribute to any project, take this into consideration 😁

[kencam]

I can also confirm this. I changed setInterval to 1000, setFastestInterval to 500 and timeout to 1000 and it is working normally now.

[CoooWeee]

@tripodsgames I agree about the missing feature. But fastestInterval is deprecated. I would suggest bumping playServicesLocationVersion to '21.0.1' and using LocationRequest.Builder

Here the code:

                LocationRequest locationRequest = new LocationRequest.Builder(priority, timeout) // instead of setPriority & setInterval
                        .setMinUpdateIntervalMillis(minUpdateInterval) // instead of fastestInterval
                        .setMaxUpdateDelayMillis(timeout) // instead of setMaxWaitTime
                        .build();

[szundi]

@CoooWeee really thanks for spending the effort on replying, will try and report back with the results.

[tripodsgames]

@tripodsgames I agree about the missing feature. But fastestInterval is deprecated. I would suggest bumping playServicesLocationVersion to '21.0.1' and using LocationRequest.Builder

Here the code:

                LocationRequest locationRequest = new LocationRequest.Builder(priority, timeout) // instead of setPriority & setInterval
                        .setMinUpdateIntervalMillis(minUpdateInterval) // instead of fastestInterval
                        .setMaxUpdateDelayMillis(timeout) // instead of setMaxWaitTime
                        .build();

I opened this issue a long time ago, I'll update with your suggestion

[pirex360]

Any news about this? for real-time tracking with fast movement...this is a pain, can you explain better where to put the code above?

[pirex360]

Ok, I get it. It's on Geolocation.java file in the capacitor plugin folder/geolocation

I changed to this, but it doesn't get the same results as google maps... it's not smoother to watch the location, it takes about 1 second to retrieve...and the position jumps a lot, I tried to play around with the values...it is quicker now...but still away from optimum results

in Geolocation.java file :

...
                LocationRequest locationRequest = new LocationRequest.Builder(1000)
                    .setMaxUpdateDelayMillis(100)
                    .setMinUpdateIntervalMillis(50)
                    .setPriority(priority)
                    .build();
...

In my service file :

this.watchId = Geolocation.watchPosition({enableHighAccuracy: true,}, (position, err) => {
     
        this.lat = position!.coords.latitude;
        this.lng = position!.coords.longitude;
        this.coords = [this.lat, this.lng];
        
        ...

     

    })