Merge pull request #213 from ionide/bump-fcs-to-8.0.300

update FCS and FSharp.Core for the new release

Author: baronfel

CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres
 to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.26.0] - 2024-05-15
+
+### Changed
+
+* [Emit Analyzer Errors in the MSBuild Canonical Error Format](https://github.com/ionide/FSharp.Analyzers.SDK/pull/208) (thanks @Numpsy!)
+* [Update Structured Logger libraries](https://github.com/ionide/FSharp.Analyzers.SDK/pull/211) (thanks @nojaf!)
+* Update FSharp.Compiler.Service and FSharp.Core to the .NET SDK 8.0.300 release versions
+
 ## [0.25.0] - 2024-02-14
 
 ### Changed

Directory.Packages.props

@@ -5,18 +5,18 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageVersion Include="CliWrap" Version="3.6.4" />
-    <PackageVersion Include="FSharp.Core" Version="[8.0.200]" />
-    <PackageVersion Include="FSharp.Compiler.Service" Version="[43.8.200]" />
+    <PackageVersion Include="FSharp.Core" Version="[8.0.300]" />
+    <PackageVersion Include="FSharp.Compiler.Service" Version="[43.8.300]" />
     <PackageVersion Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" PrivateAssets="all" />
     <PackageVersion Include="McMaster.NETCore.Plugins" Version="1.4.0" />
     <PackageVersion Include="Argu" Version="6.1.1" />
     <PackageVersion Include="Glob" Version="1.1.9" />
-    <PackageVersion Include="Ionide.ProjInfo.ProjectSystem" Version="0.63.0" />
+    <PackageVersion Include="Ionide.ProjInfo.ProjectSystem" Version="0.65.0" />
     <PackageVersion Include="Microsoft.Build" Version="$(MsBuildPackageVersion)" ExcludeAssets="runtime" />
     <PackageVersion Include="Microsoft.Build.Framework" Version="$(MsBuildPackageVersion)" ExcludeAssets="runtime" />
     <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="$(MsBuildPackageVersion)" ExcludeAssets="runtime" />
     <PackageVersion Include="Microsoft.Build.Utilities.Core" Version="$(MsBuildPackageVersion)" ExcludeAssets="runtime" />
-    <PackageVersion Include="Microsoft.Build.Locator" Version="1.4.1" />
+    <PackageVersion Include="Microsoft.Build.Locator" Version="1.7.8" />
     <!-- Need to update Directory.Build.props DotNet.ReproducibleBuilds.Isolated version when updating this-->
     <PackageVersion Include="DotNet.ReproducibleBuilds" Version="1.1.1" PrivateAssets="All" />
     <PackageVersion Include="Microsoft.Extensions.Logging" Version="6.0.0" />

src/FSharp.Analyzers.SDK/ASTCollecting.fs

@@ -25,14 +25,6 @@ module ASTCollecting =
         | SynArgPats.Pats ps -> ps
         | SynArgPats.NamePatPairs(pats = xs) -> xs |> List.map (fun (_, _, pat) -> pat)
 
-    /// A pattern that collects all patterns from a `SynSimplePats` into a single flat list
-    let (|AllSimplePats|) (pats: SynSimplePats) =
-        let rec loop acc pat =
-            match pat with
-            | SynSimplePats.SimplePats(pats = pats) -> acc @ pats
-
-        loop [] pats
-
     type SyntaxCollectorBase() =
         abstract WalkSynModuleOrNamespace: path: SyntaxVisitorPath * SynModuleOrNamespace -> unit
         default _.WalkSynModuleOrNamespace(_, _) = ()
@@ -493,9 +485,9 @@ module ASTCollecting =
             match s with
             | SynMemberDefn.AbstractSlot(slotSig = valSig) -> walkValSig nextPath valSig
             | SynMemberDefn.Member(binding, _) -> walkBinding nextPath binding
-            | SynMemberDefn.ImplicitCtor(attributes = AllAttrs attrs; ctorArgs = AllSimplePats pats) ->
+            | SynMemberDefn.ImplicitCtor(attributes = AllAttrs attrs; ctorArgs = pats) ->
                 List.iter (walkAttribute nextPath) attrs
-                List.iter (walkSimplePat nextPath) pats
+                walkPat nextPath pats
             | SynMemberDefn.ImplicitInherit(inheritType = t; inheritArgs = e) ->
                 walkType nextPath t
                 walkExpr nextPath e