Skip to content

Commit 12dd03d

Browse files
committed
Prevent handler from redirecting *.resources.dll
Thanks to @ryun for this patch. These assemblies are found in localized versions of MSBuild v14 and fail to load, which then causes an infinite loop to occur in the event handler.
1 parent a9fbec7 commit 12dd03d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

FsAutoComplete/CompilerServiceInterface.fs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ module CompilerServiceInterface =
162162
let addMSBuildv14BackupResolution () =
163163
let onResolveEvent = new ResolveEventHandler( fun sender evArgs ->
164164
let requestedAssembly = AssemblyName(evArgs.Name)
165-
if requestedAssembly.Name.StartsWith("Microsoft.Build") then
165+
if requestedAssembly.Name.StartsWith("Microsoft.Build") &&
166+
not (requestedAssembly.Name.EndsWith(".resources")) then
166167
requestedAssembly.Version <- Version("14.0.0.0")
167168
Assembly.Load (requestedAssembly)
168169
else

0 commit comments

Comments
 (0)