Enhance documentation for findPartialActivePatternCaseUsages and optimize case name extraction in AdaptiveServerState

Author: TheAngryByrd

src/FsAutoComplete.Core/Commands.fs

@@ -107,8 +107,13 @@ module Commands =
     |> Array.filter (fun s -> not (String.IsNullOrWhiteSpace(s)))
     |> Array.toList
 
-  /// Find case usages for partial active patterns by walking the AST
-  /// Returns ranges where the case names appear in pattern matches
+  /// Finds usages of partial active pattern cases by walking the AST.
+  ///
+  /// Returns syntactic ranges from the AST where the specified case names appear in pattern matches.
+  /// For qualified identifiers (e.g., `MyModule.ParseInt`), returns the full qualified range to match FCS behavior.
+  /// Recursively traverses all pattern forms, including nested and composite patterns (tuples, lists, or/and/as patterns, etc.).
+  ///
+  /// Note: Only syntactic (AST) ranges are returned; semantic information is not considered.
   let findPartialActivePatternCaseUsages (caseNames: string list) (parseResults: FSharpParseFileResults) : range list =
     let rec walkPat (pat: SynPat) =
       seq {
@@ -270,7 +275,7 @@ module Commands =
     | ParsedInput.ImplFile(ParsedImplFileInput(contents = modules)) ->
       modules
       |> List.collect (fun (SynModuleOrNamespace(decls = decls)) -> decls |> List.collect (walkDecl >> Seq.toList))
-      |> List.distinct
+      |> List.distinctBy (fun r -> r.Start, r.End)
     | _ -> []
 
   let addFile (fsprojPath: string) fileVirtPath =

src/FsAutoComplete/LspServers/AdaptiveServerState.fs

@@ -1173,10 +1173,9 @@ type AdaptiveState
           binlogConfig
           |> addAValLogging (fun () -> logger.info (Log.setMessage "Loading projects because binlogConfig change"))
 
-        let! projects =
-          // need to bind to a single value to keep the threadpool from being exhausted as LoadingProjects can be a long running operation
-          // and when other adaptive values await on this, the scheduler won't block those other tasks
-          loadProjects loader binlogConfig projects |> AMap.toAVal
+        // need to bind to a single value to keep the threadpool from being exhausted as LoadingProjects can be a long running operation
+        // and when other adaptive values await on this, the scheduler won't block those other tasks
+        let! projects = loadProjects loader binlogConfig projects |> AMap.toAVal
 
         and! checker = checker
         checker.ClearCaches()
@@ -2208,10 +2207,7 @@ type AdaptiveState
             match! forceGetOpenFileTypeCheckResultsStale file with
             | Error _ -> return baseRanges
             | Ok tyRes ->
-              let caseNames =
-                patternDisplayName.TrimStart('|', '(').TrimEnd('|', '_', ')').Split('|')
-                |> Array.filter (fun s -> not (System.String.IsNullOrWhiteSpace(s)))
-                |> Array.toList
+              let caseNames = Commands.extractActivePatternCaseNames patternDisplayName
 
               let caseUsageRanges =
                 Commands.findPartialActivePatternCaseUsages caseNames tyRes.GetParseResults