Using simple dictionary for msbuild props

Author: TheAngryByrd

src/FsAutoComplete/LspHelpers.fs

@@ -610,7 +610,7 @@ type NotificationsDto =
     TraceNamespaces: string array option }
 
 type BuildOptionsDto =
-  { MsBuildProperties: string array option }
+  { MsBuildProperties: Dictionary<string,string> option }
 
 type DebugDto =
   { DontCheckRelatedFiles: bool option
@@ -730,16 +730,24 @@ type FSACConfig =
   member this.AddDto(dto: FSACDto) =
     { CachedTypeCheckCount = defaultArg dto.CachedTypeCheckCount this.CachedTypeCheckCount }
 type BuildOptions =
-  { MsBuildProperties: string array }
+  { MsBuildProperties: Map<string, string> }
 
-  static member Default = { MsBuildProperties = [||] }
+  static member Default = { MsBuildProperties = Map.empty }
 
   static member FromDto(dto: BuildOptionsDto) : BuildOptions =
-    { MsBuildProperties = defaultArg dto.MsBuildProperties BuildOptions.Default.MsBuildProperties }
+    let props =
+      dto.MsBuildProperties
+      |> Option.map ( Seq.map (|KeyValue|) >> Map.ofSeq)
+
+    { MsBuildProperties = defaultArg props BuildOptions.Default.MsBuildProperties }
 
 
   member this.AddDto(dto: BuildOptionsDto) : BuildOptions =
-    { MsBuildProperties = defaultArg dto.MsBuildProperties this.MsBuildProperties }
+    let props =
+      dto.MsBuildProperties
+      |> Option.map ( Seq.map (|KeyValue|) >> Map.ofSeq)
+
+    { MsBuildProperties = defaultArg props this.MsBuildProperties }
 
 type DebugConfig =
   { DontCheckRelatedFiles: bool

src/FsAutoComplete/LspServers/AdaptiveFSharpLspServer.fs

@@ -515,16 +515,7 @@ type AdaptiveFSharpLspServer(workspaceLoader: Map<string, string> -> IWorkspaceL
       let! loaderFactory = loaderFactory
       and! config = config
 
-      let props =
-        config.BuildOptions.MsBuildProperties
-        |> Array.choose(fun s ->
-          match s.Split("=") |> Array.toList with
-          | head::shoulders::_ -> Some(head,shoulders)
-          | _ -> None
-        )
-        |> Map.ofArray
-
-      return loaderFactory props
+      return loaderFactory config.BuildOptions.MsBuildProperties
     }