Add Logging to FSharp.Analyzer.SDK (#1413)

* Add Serilog.Extensions.Logging to paket.dependencies and references

* Add logging to FSharp.Analyzers.SDK

* Change FsAutocomplete analyzer name to be less ambigious from Analyzer SDK

Author: TheAngryByrd

paket.dependencies

@@ -30,6 +30,7 @@ nuget Serilog >= 2.10.0
 nuget Serilog.Sinks.File >= 5.0.0
 nuget Serilog.Sinks.Console >= 4.0.0
 nuget Serilog.Sinks.Async >= 1.5
+nuget Serilog.Extensions.Logging
 nuget Destructurama.FSharp
 nuget FSharp.UMX >= 1.1
 nuget FSharp.Formatting >= 14.0

paket.lock

@@ -487,6 +487,9 @@ NUGET
     Serilog (4.1)
       System.Diagnostics.DiagnosticSource (>= 8.0.1) - restriction: || (&& (== net8.0) (>= net462) (< netstandard2.0)) (&& (== net8.0) (>= net471)) (&& (== net8.0) (< net6.0)) (&& (== net9.0) (>= net462) (< netstandard2.0)) (&& (== net9.0) (>= net471)) (&& (== net9.0) (< net6.0)) (== netstandard2.0) (== netstandard2.1)
       System.Threading.Channels (>= 8.0) - restriction: || (&& (== net8.0) (>= net462) (< netstandard2.0)) (&& (== net8.0) (>= net471)) (&& (== net8.0) (< net6.0)) (&& (== net9.0) (>= net462) (< netstandard2.0)) (&& (== net9.0) (>= net471)) (&& (== net9.0) (< net6.0)) (== netstandard2.0) (== netstandard2.1)
+    Serilog.Extensions.Logging (8.0)
+      Microsoft.Extensions.Logging (>= 8.0)
+      Serilog (>= 3.1.1)
     Serilog.Sinks.Async (2.1)
       Serilog (>= 4.1)
     Serilog.Sinks.Console (6.0)

src/FsAutoComplete.Core/Debug.fs

@@ -8,7 +8,7 @@ namespace FsAutoComplete
 module Loggers =
   open FsAutoComplete.Logging
 
-  let analyzers = LogProvider.getLoggerByName "Analyzers"
+  let analyzers = LogProvider.getLoggerByName "FsAutoComplete.Analyzers"
 
 
 [<RequireQualifiedAccess>]

src/FsAutoComplete.Core/paket.references

@@ -16,3 +16,4 @@ Ionide.ProjInfo.ProjectSystem
 FSharp.Analyzers.SDK
 Ionide.Analyzers
 FSharp.Analyzers.Build
+Serilog.Extensions.Logging

src/FsAutoComplete/LspServers/AdaptiveServerState.fs

@@ -39,7 +39,7 @@ open FsAutoComplete.Lsp.Helpers
 open FSharp.Compiler.Syntax
 open FsAutoComplete.ProjectWorkspace
 open FSharp.Analyzers.SDK
-
+open Serilog.Extensions.Logging
 
 /// <summary>Handle tracking in-flight ServerProgressReport and allow cancellation of actions if a client decides to.</summary>
 type ServerProgressLookup() =
@@ -170,13 +170,14 @@ type AdaptiveState
   let progressLookup = new ServerProgressLookup()
   do disposables.Add progressLookup
 
+  let serilogLoggerFactory = new SerilogLoggerFactory(Serilog.Log.Logger)
+  do disposables.Add serilogLoggerFactory
 
   let projectSelector = cval<IFindProject> (FindFirstProject())
 
   let rootPath = cval<string option> None
 
   let config = cval<FSharpConfig> FSharpConfig.Default
-  // let useTransparentCompiler = cval<bool> true
 
   let checker =
     config
@@ -223,9 +224,10 @@ type AdaptiveState
       [| yield! fsiCompilerToolLocations |> Array.map toCompilerToolArgument
          yield! fsiExtraParameters |]
 
+
   let analyzersClient =
     FSharp.Analyzers.SDK.Client<FSharp.Analyzers.SDK.EditorAnalyzerAttribute, FSharp.Analyzers.SDK.EditorContext>(
-      Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance
+      serilogLoggerFactory.CreateLogger "FSharp.Analyzers.SDK"
     )
 
   /// <summary>Loads F# Analyzers from the configured directories</summary>
@@ -268,7 +270,7 @@ type AdaptiveState
 
           Loggers.analyzers.info (
             Log.setMessageI
-              $"From {analyzerPath:name}: {assemblyLoadStats.AnalyzerAssemblies:dllNo} dlls including {assemblyLoadStats.Analyzers:analyzersNo} analyzers"
+              $"From {analyzerPath:name}: {assemblyLoadStats.AnalyzerAssemblies:dllNo} dlls including {assemblyLoadStats.Analyzers:analyzersNo} analyzers with {assemblyLoadStats.FailedAssemblies:failedAssemblies} failed assemblies"
           ))
 
     else