Update project to support .NET 10 and upgrade dependencies (#1429)

* Update project to support .NET 10 and upgrade dependencies

- Updated paket version to 10.0.0-alpha011 in dotnet-tools.json.
- Modified GitHub workflows to include .NET 10 builds and tests.
- Updated project files to target .NET 10 alongside .NET 8 and 9.
- Upgraded FSharp.Compiler.Service and related dependencies to compatible versions.
- Removed deprecated LetOrUseBang pattern matching in various files.
- Enhanced code generation utilities to accommodate new patterns and attributes.

* Refactor parser options and command handling

- Updated the AdaptiveServerState.fs to use `let!` instead of `and!` for better readability.
- Refactored the Parser.fs to streamline option creation by removing redundant arity setting functions and using a more concise approach.
- Changed the way options are added to the root command, improving clarity and consistency.
- Simplified the command handling logic by breaking it into smaller functions for better maintainability.
- Updated the Parser.fsi to reflect the new `invoke` function signature.
- Modified Program.fs to call the new `invoke` function instead of the old parser.
- Adjusted test helper to ensure timeout values are correctly converted to float.

* Fix tests

* Remove unused state directory option from root command action

* Fix formatting of type annotations in test cases

* Update project file to support multiple target frameworks for .NET 9 and 10

* Remove conditional target frameworks for .NET 9 and 10 from test project file

* Revert SDK version and rollForward settings in global.json to previous configuration

* Refactor build pipeline to use toolRestore stage and add tests for .NET 8, 9, and 10

* Update Ionide.Analyzers to version 0.14.10 in paket.dependencies and paket.lock

Author: TheAngryByrd

.config/dotnet-tools.json

@@ -3,7 +3,7 @@
   "isRoot": true,
   "tools": {
     "paket": {
-      "version": "9.0.2",
+      "version": "10.0.0-alpha011",
       "commands": [
         "paket"
       ],
@@ -38,4 +38,4 @@
       "rollForward": false
     }
   }
-}
+}

.github/workflows/build.yml

@@ -27,7 +27,7 @@ jobs:
           - windows-latest
           - macos-15
           - ubuntu-latest
-        dotnet-version: ["8.0.x", "9.0.x"]
+        dotnet-version: ["8.x", "9.x", "10.x"]
         use-transparent-compiler:
           - "TransparentCompiler"
           - "BackgroundCompiler"
@@ -38,18 +38,28 @@ jobs:
         include:
           # latest 8.0
           - global-json-file: "global.json"
-            dotnet-version: "8.0.x"
+            dotnet-version: "8.x"
             include-prerelease: false
             label: "8.0"
             build_net9: false
+            build_net10: false
             test_tfm: net8.0
           # latest 9.0
           - global-json-file: "global.json"
-            dotnet-version: "9.0.x"
+            dotnet-version: "9.x"
             include-prerelease: true
             label: "9.0"
             build_net9: true
+            build_net10: false
             test_tfm: net9.0
+          # latest 10.0
+          - global-json-file: "global.json"
+            dotnet-version: "10.x"
+            include-prerelease: true
+            label: "10.0"
+            build_net9: false
+            build_net10: true
+            test_tfm: net10.0
       fail-fast: false # we have timing issues on some OS, so we want them all to run
 
     runs-on: ${{ matrix.os }}
@@ -98,12 +108,14 @@ jobs:
       run: dotnet build -c Release
       env:
         BuildNet9: ${{ matrix.build_net9 }}
+        BuildNet10: ${{ matrix.build_net10 }}
 
     - name: Run and report tests
       run: dotnet test -c Release -f ${{ matrix.test_tfm }} --no-restore --no-build  --logger "console;verbosity=normal" --logger GitHubActions /p:AltCover=true /p:AltCoverAssemblyExcludeFilter="System.Reactive|FSharp.Compiler.Service|Ionide.ProjInfo|FSharp.Analyzers|Analyzer|Humanizer|FSharp.Core|FSharp.DependencyManager" -- Expecto.fail-on-focused-tests=true --blame-hang --blame-hang-timeout 1m
       working-directory: test/FsAutoComplete.Tests.Lsp
       env:
         BuildNet9: ${{ matrix.build_net9 }}
+        BuildNet10: ${{ matrix.build_net10 }}
         USE_TRANSPARENT_COMPILER: ${{ matrix.use-transparent-compiler }}
         USE_WORKSPACE_LOADER: ${{ matrix.workspace-loader }}
 

.github/workflows/release.yml

@@ -23,8 +23,9 @@ jobs:
         uses:  actions/setup-dotnet@v4
         with:
           dotnet-version: |
-           8.0.x
-           9.0.x
+           8.x
+           9.x
+           10.x
 
       - name: Restore tools
         run: dotnet tool restore
@@ -33,6 +34,7 @@ jobs:
         run: dotnet pack -c Release -o ./bin
         env:
           BuildNet9: true
+          BuildNet10: true
 
       - name: Get Changelog Entry
         id: changelog_reader

Directory.Build.props

@@ -12,6 +12,7 @@
     variables,https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/compiler-options#opt-in-warnings -->
     <NoWarn>$(NoWarn);FS0044</NoWarn>       <!-- Ignore deprecations -->
     <NoWarn>$(NoWarn);FS3397</NoWarn> <!--  This expression uses unit for an obj-typed argument. This will lead to passing null at runtime -->
+    <NoWarn>$(NoWarn);NU1510</NoWarn> <!-- PackageReference will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary -->
     <WarnOn>$(WarnOn);3390</WarnOn><!-- Malformed XML doc comments -->
 
         <!-- Package Reference with no usable assets -->

benchmarks/benchmarks.fsproj

@@ -4,6 +4,7 @@
     <OutputType>Exe</OutputType>
     <TargetFrameworks>net8.0</TargetFrameworks>
     <TargetFrameworks Condition="'$(BuildNet9)' == 'true'">net8.0;net9.0</TargetFrameworks>
+    <TargetFrameworks Condition="'$(BuildNet10)' == 'true'">net8.0;net9.0;net10.0</TargetFrameworks>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="SourceTextBenchmarks.fs" />

build.fsx

@@ -6,6 +6,8 @@
 open Fun.Build
 open Fake.Tools
 
+let toolRestore = stage "ToolRestore" { run "dotnet tool restore" }
+
 module ScaffoldCodeFix =
   open System
   open System.IO
@@ -424,11 +426,61 @@ pipeline "Build" {
   workingDir __SOURCE_DIRECTORY__
 
   stage "Build" {
-    run "dotnet tool restore"
+    toolRestore
     run "dotnet build"
   }
 
-  runIfOnlySpecified false
+// runIfOnlySpecified false
+}
+
+
+let (</>) a b = System.IO.Path.Combine(a, b)
+
+
+let lspTestsPath = (__SOURCE_DIRECTORY__ </> "test" </> "FsAutoComplete.Tests.Lsp")
+
+/// Ionide.ProjInfo loads the current SDK's MsBuild library so we need to ensure we
+/// run on the version associated with the SDK we want to test against.
+/// https://learn.microsoft.com/en-us/dotnet/core/deploying/?pivots=cli#framework-dependent-deployment
+let createGlobalJson sdkVersion =
+  $"dotnet new globaljson --force --sdk-version %s{sdkVersion} --roll-forward LatestMinor"
+
+let net80Tests =
+  stage "test:net8.0" {
+    workingDir lspTestsPath
+    run (createGlobalJson "8.0.300")
+    toolRestore
+    run "dotnet test -c Release -f net8.0"
+    run (fun _ -> System.IO.File.Delete(lspTestsPath </> "global.json"))
+  }
+
+let net90Tests =
+  stage "test:net9.0" {
+    workingDir lspTestsPath
+    envVars [ "BuildNet9", "true" ]
+    run (createGlobalJson "9.0.100")
+    toolRestore
+    run "dotnet test -c Release -f net9.0"
+    run (fun _ -> System.IO.File.Delete(lspTestsPath </> "global.json"))
+  }
+
+let net100Tests =
+  stage "test:net10.0" {
+    workingDir lspTestsPath
+    envVars [ "BuildNet10", "true" ]
+    run (createGlobalJson "10.0.100")
+    toolRestore
+    run "dotnet test -c Release -f net10.0"
+    run (fun _ -> System.IO.File.Delete(lspTestsPath </> "global.json"))
+  }
+
+
+pipeline "Tests" {
+  description "Run all tests"
+  net80Tests
+  net90Tests
+  net100Tests
+  runIfOnlySpecified true
 }
 
 tryPrintPipelineCommandHelp ()

paket.dependencies

@@ -1,28 +1,30 @@
 version 7.2.1
 
-framework: netstandard2.0, netstandard2.1, net8.0, net9.0
+framework: netstandard2.0, netstandard2.1, net8.0, net9.0, net10.0
 
 source https://api.nuget.org/v3/index.json
 # this is the FCS nightly feed, re-enable at your own risk!
 # source: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json
 # source: ./libs
 storage: none
+lowest_matching:true
+strategy: min
 
 nuget BenchmarkDotNet
 nuget Fantomas.Client >= 0.9
-nuget FSharp.Compiler.Service >= 43.9.300
-nuget Ionide.Analyzers 0.14.9
+nuget FSharp.Compiler.Service >= 43.10.100
+nuget Ionide.Analyzers 0.14.10
 nuget FSharp.Analyzers.Build
-nuget Ionide.ProjInfo >= 0.72.0
-nuget Ionide.ProjInfo.FCS >= 0.72.0
-nuget Ionide.ProjInfo.ProjectSystem >= 0.72.0
+nuget Ionide.ProjInfo >= 0.73.0
+nuget Ionide.ProjInfo.FCS >= 0.73.0
+nuget Ionide.ProjInfo.ProjectSystem >= 0.73.0
 nuget Microsoft.Build >= 17.2 copy_local:false
 nuget Microsoft.Build.Framework >= 17.4 copy_local:false
 nuget Microsoft.Build.Utilities.Core >= 17.4 copy_local:false
 nuget Microsoft.Build.Tasks.Core >= 17.4 copy_local: false
 nuget Nuget.Frameworks >= 6.3 copy_local: false
 nuget Microsoft.CodeAnalysis
-nuget FSharp.Analyzers.SDK 0.33.1
+nuget FSharp.Analyzers.SDK 0.34.1
 nuget ICSharpCode.Decompiler
 nuget Mono.Cecil >= 0.11.4
 nuget FSharpLint.Core
@@ -34,11 +36,12 @@ nuget Serilog.Extensions.Logging
 nuget Destructurama.FSharp
 nuget FSharp.UMX >= 1.1
 nuget FSharp.Formatting >= 14.0
-nuget FsToolkit.ErrorHandling.TaskResult >= 4.4 framework: netstandard2.1, net8.0, net9.0
+nuget FsToolkit.ErrorHandling < 5
+nuget FsToolkit.ErrorHandling.TaskResult < 5
 nuget IcedTasks >= 0.11.7
 nuget FSharpx.Async >= 1.14
 nuget CliWrap >= 3.0
-nuget System.CommandLine prerelease
+nuget System.CommandLine 2.0
 nuget FSharp.Data.Adaptive >= 1.2
 nuget Microsoft.NET.Test.Sdk >= 17.4
 nuget Dotnet.ReproducibleBuilds copy_local:true