Enable unnecessary parentheses analyzer by default (#1336)

* Enable unnecessary parentheses analyzer by default

* Remove unnecessary parens in tests

Author: brianrourkeboll

src/FsAutoComplete/LspHelpers.fs

@@ -876,7 +876,7 @@ type FSharpConfig =
       UnusedDeclarationsAnalyzerExclusions = [||]
       SimplifyNameAnalyzer = false
       SimplifyNameAnalyzerExclusions = [||]
-      UnnecessaryParenthesesAnalyzer = false
+      UnnecessaryParenthesesAnalyzer = true
       ResolveNamespaces = false
       EnableReferenceCodeLens = false
       EnableAnalyzers = false
@@ -929,7 +929,7 @@ type FSharpConfig =
       SimplifyNameAnalyzerExclusions =
         defaultArg dto.SimplifyNameAnalyzerExclusions [||]
         |> Array.choose tryCreateRegex
-      UnnecessaryParenthesesAnalyzer = defaultArg dto.UnnecessaryParenthesesAnalyzer false
+      UnnecessaryParenthesesAnalyzer = defaultArg dto.UnnecessaryParenthesesAnalyzer true
       ResolveNamespaces = defaultArg dto.ResolveNamespaces false
       EnableReferenceCodeLens = defaultArg dto.EnableReferenceCodeLens false
       EnableAnalyzers = defaultArg dto.EnableAnalyzers false

test/FsAutoComplete.Tests.Lsp/FindReferencesTests.fs

@@ -518,15 +518,15 @@ let private rangeTests state =
         open System
         open System.Threading.Tasks
         let _ = task {
-          do! Task.$<De$0lay>$ (TimeSpan.MaxValue)
-          do! Task.$<``Delay``>$ (TimeSpan.MaxValue)
-          do! System.Threading.Tasks.Task.$<Delay>$ (TimeSpan.MaxValue)
+          do! Task.$<De$0lay>$ TimeSpan.MaxValue
+          do! Task.$<``Delay``>$ TimeSpan.MaxValue
+          do! System.Threading.Tasks.Task.$<Delay>$ TimeSpan.MaxValue
           do!
             System
               .Threading
               .Tasks
               .Task
-              .$<Delay>$ (TimeSpan.MaxValue)
+              .$<Delay>$ TimeSpan.MaxValue
         }
         """
       testCaseAsync "can get range of variable with required backticks"
@@ -616,15 +616,15 @@ let private rangeTests state =
         open System
         open System.Threading.Tasks
         let _ = task {
-          do! $<Ta$0sk>$.Delay(TimeSpan.MaxValue)
-          do! $<Task>$.``Delay`` (TimeSpan.MaxValue)
-          do! System.Threading.Tasks.$<Task>$.Delay (TimeSpan.MaxValue)
+          do! $<Ta$0sk>$.Delay TimeSpan.MaxValue
+          do! $<Task>$.``Delay`` TimeSpan.MaxValue
+          do! System.Threading.Tasks.$<Task>$.Delay TimeSpan.MaxValue
           do!
             System
               .Threading
               .Tasks
               .$<Task>$
-              .Delay (TimeSpan.MaxValue)
+              .Delay TimeSpan.MaxValue
         }
         """ ])