Skip to content

Commit 8311a5f

Browse files
committed
support multitargeting too
1 parent 57749d4 commit 8311a5f

File tree

6 files changed

+49
-22
lines changed

6 files changed

+49
-22
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
## [0.1.4] - 2022.03.20
4+
5+
### Fixed
6+
7+
- Support supplying package versions for project-to-project references in multitargeting scenarios.
8+
9+
310
## [0.1.3] - 2022.03.20
411

512
### Fixed

src/Directory.Build.props

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<Project>
2+
<PropertyGroup>
3+
<Version>0.1.4</Version>
4+
<PackageReleaseNotes>
5+
### Fixed
6+
7+
- Support supplying package versions for project-to-project references in multitargeting scenarios.
8+
</PackageReleaseNotes>
9+
</PropertyGroup>
10+
</Project>

src/Ionide.KeepAChangelog.Tasks/Ionide.KeepAChangelog.Tasks.fsproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@
88
<DebugType>embedded</DebugType>
99
<IsPackable>true</IsPackable>
1010
<Description>MSBuild Tasks and Targets that set your Assembly Version, Package Version, and Package Release Notes from your KeepAChangelog-compatible Changelogs.</Description>
11-
<Version>0.1.3</Version>
12-
<PackageReleaseNotes>
13-
### Fixed
14-
15-
- Support supplying package versions for project-to-project references.
16-
</PackageReleaseNotes>
1711
</PropertyGroup>
1812

1913
<ItemGroup>

src/Ionide.KeepAChangelog.Tasks/build/Ionide.KeepAChangelog.Tasks.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
</PrepareForBuildDependsOn>
1313
<!-- For project-to-project dependencies, GetPackageVersionDependsOn can be used as a well-known hook to ensure the project's versioning properties are run. -->
1414
<GetPackageVersionDependsOn>
15-
$(GetPackageVersionDependsOn);
1615
SetVersionFromChangelog
16+
$(GetPackageVersionDependsOn);
1717
</GetPackageVersionDependsOn>
1818
</PropertyGroup>
1919

src/Ionide.KeepAChangelog.Tasks/buildMultiTargeting/Ionide.KeepAChangelog.Tasks.targets

Lines changed: 31 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
2-
<UsingTask AssemblyFile="$(MSBuildThisFileDirectory)../lib/netstandard2.0/Ionide.KeepAChangelog.Tasks.dll" TaskName="Ionide.KeepAChangelog.Tasks.ParseChangeLogs" />
2+
<UsingTask
3+
AssemblyFile="$(MSBuildThisFileDirectory)../lib/netstandard2.0/Ionide.KeepAChangelog.Tasks.dll"
4+
TaskName="Ionide.KeepAChangelog.Tasks.ParseChangeLogs" />
35

46
<PropertyGroup>
57
<!-- For multitargeting builds, the 'outer' build is used for things like packing, and so never hits the `PrepareForBuildDependsOn` condition group
@@ -9,27 +11,47 @@
911
<GenerateNuspecDependsOn>
1012
SetVersionFromChangelog;
1113
$(GenerateNuspecDependsOn)
12-
</GenerateNuspecDependsOn>
14+
</GenerateNuspecDependsOn>
15+
<GetPackageVersionDependsOn>
16+
SetVersionFromChangelog
17+
$(GetPackageVersionDependsOn);
18+
</GetPackageVersionDependsOn>
1319
</PropertyGroup>
1420

15-
<Target Name="GetChangelogVersion" Condition="'$(ChangelogFile)' != '' and Exists('$(ChangelogFile)')" Inputs="$(ChangelogFile)" Outputs="UnreleasedChangelog;CurrentReleaseChangelog;AllReleasedChangelogslLatestReleaseNotes">
21+
<Target
22+
Name="GetChangelogVersion"
23+
Condition="'$(ChangelogFile)' != '' and Exists('$(ChangelogFile)')"
24+
Inputs="$(ChangelogFile)"
25+
Outputs="UnreleasedChangelog;CurrentReleaseChangelog;AllReleasedChangelogslLatestReleaseNotes">
1626
<Ionide.KeepAChangelog.Tasks.ParseChangeLogs ChangelogFile="$(ChangelogFile)">
17-
<Output TaskParameter="UnreleasedChangelog" ItemName="UnreleasedChangelog" />
18-
<Output TaskParameter="CurrentReleaseChangelog" ItemName="CurrentReleaseChangelog" />
19-
<Output TaskParameter="AllReleasedChangelogs" ItemName="AllReleasedChangelogs" />
20-
<Output TaskParameter="LatestReleaseNotes" ItemName="LatestReleaseNotes" />
27+
<Output
28+
TaskParameter="UnreleasedChangelog"
29+
ItemName="UnreleasedChangelog" />
30+
<Output
31+
TaskParameter="CurrentReleaseChangelog"
32+
ItemName="CurrentReleaseChangelog" />
33+
<Output
34+
TaskParameter="AllReleasedChangelogs"
35+
ItemName="AllReleasedChangelogs" />
36+
<Output
37+
TaskParameter="LatestReleaseNotes"
38+
ItemName="LatestReleaseNotes" />
2139
</Ionide.KeepAChangelog.Tasks.ParseChangeLogs>
2240
</Target>
2341

24-
<Target Name="SetVersionFromChangelog" DependsOnTargets="GetChangelogVersion">
42+
<Target
43+
Name="SetVersionFromChangelog"
44+
DependsOnTargets="GetChangelogVersion">
2545
<PropertyGroup Condition="'@(CurrentReleaseChangelog)' != ''">
2646
<Version>%(CurrentReleaseChangelog.Identity)</Version>
2747
<PackageVersion>%(CurrentReleaseChangelog.Identity)</PackageVersion>
2848
<PackageReleaseNotes>@(LatestReleaseNotes)</PackageReleaseNotes>
2949
</PropertyGroup>
3050

3151
<ItemGroup Condition="'@(CurrentReleaseChangelog)' != '' and '$(GenerateAssemblyInfo)' == 'true'">
32-
<AssemblyAttribute Include="System.Reflection.AssemblyMetadataAttribute" Condition="'$(GenerateRepositoryUrlAttribute)' == 'true' and ('$(RepositoryUrl)' != '' or '$(PublishRepositoryUrl)' == 'true')">
52+
<AssemblyAttribute
53+
Include="System.Reflection.AssemblyMetadataAttribute"
54+
Condition="'$(GenerateRepositoryUrlAttribute)' == 'true' and ('$(RepositoryUrl)' != '' or '$(PublishRepositoryUrl)' == 'true')">
3355
<_Parameter1>BuildDate</_Parameter1>
3456
<_Parameter2>%(CurrentReleaseChangelog.Date)</_Parameter2>
3557
</AssemblyAttribute>

src/Ionide.KeepAChangelog/Ionide.KeepAChangelog.fsproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
<DebugType>embedded</DebugType>
77
<IsPackable>true</IsPackable>
88
<Description>A self-contained parser for the KeepAChangelog format.</Description>
9-
<Version>0.1.3</Version>
10-
<PackageReleaseNotes>
11-
### Fixed
12-
13-
- Support supplying package versions for project-to-project references.
14-
</PackageReleaseNotes>
159
</PropertyGroup>
1610

1711
<ItemGroup>

0 commit comments

Comments
 (0)