move server types to raw interfaces with members matching method names

Author: baronfel

src/Client.fs

@@ -2,14 +2,6 @@ namespace Ionide.LanguageServerProtocol
 
 open Ionide.LanguageServerProtocol.Types
 
-module private ClientUtil =
-  /// Return the JSON-RPC "not implemented" error
-  let notImplemented<'t> = async.Return LspResult.notImplemented<'t>
-
-  /// Do nothing and ignore the notification
-  let ignoreNotification = async.Return(())
-
-open ClientUtil
 
 [<AbstractClass>]
 type LspClient() =

src/Ionide.LanguageServerProtocol.fsproj

@@ -18,20 +18,34 @@
          Namespace changed from FsLibLog to LanguageServerProtocol.Logging per the instructions in that repo.
     -->
     <Compile Include="FsLibLog.fs" />
-    <Compile Include="JsonRpc.fs" />
     <Compile Include="Types.fs" />
     <Compile Include="Client.fs" />
     <Compile Include="Server.fs" />
     <Compile Include="JsonUtils.fs" />
     <Compile Include="LanguageServerProtocol.fs" />
-    <None Include="../README.md" Pack="true" PackagePath="\" />
+    <None
+        Include="../README.md"
+        Pack="true"
+        PackagePath="\" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="DotNet.ReproducibleBuilds" Version="1.1.1" PrivateAssets="All" />
-    <PackageReference Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" PrivateAssets="All" />
-    <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
+    <PackageReference
+        Include="DotNet.ReproducibleBuilds"
+        Version="1.1.1"
+        PrivateAssets="All" />
+    <PackageReference
+        Include="Ionide.KeepAChangelog.Tasks"
+        Version="0.1.8"
+        PrivateAssets="All" />
+    <PackageReference
+        Include="Newtonsoft.Json"
+        Version="13.0.1" />
     <!-- Explicitly pinning our FSharp.Core to 6.0.0 so that consumers can use _any_ 6.x version. -->
-    <PackageReference Update="FSharp.Core" Version="6.0.0" />
-    <PackageReference Include="StreamJsonRpc" Version="2.10.44" />
+    <PackageReference
+        Update="FSharp.Core"
+        Version="6.0.0" />
+    <PackageReference
+        Include="StreamJsonRpc"
+        Version="2.10.44" />
   </ItemGroup>
 </Project>

src/JsonRpc.fs

@@ -91,10 +91,9 @@ module Server =
     use jsonRpc =
       { new JsonRpc(jsonRpcHandler) with
           member this.IsFatalException(ex: Exception) =
-              match ex with
-              | :? LocalRpcException -> false
-              | _ -> true
-      }
+            match ex with
+            | :? LocalRpcException -> false
+            | _ -> true }
 
     /// When the server wants to send a notification to the client
     let sendServerNotification (rpcMethod: string) (notificationObj: obj) : AsyncLspResult<unit> =
@@ -198,18 +197,18 @@ module Server =
       "completionItem/resolve", requestHandling (fun s p -> s.CompletionItemResolve(p))
       "textDocument/rename", requestHandling (fun s p -> s.TextDocumentRename(p))
       "textDocument/prepareRename", requestHandling (fun s p -> s.TextDocumentPrepareRename(p))
-      "textDocument/definition", requestHandling (fun s p -> s.TextDocumentDefinition(p))
+      "textDocument/definition", requestHandling (fun s p -> s.``textDocument/definition`` (p))
       "textDocument/typeDefinition", requestHandling (fun s p -> s.TextDocumentTypeDefinition(p))
       "textDocument/implementation", requestHandling (fun s p -> s.TextDocumentImplementation(p))
       "textDocument/codeAction", requestHandling (fun s p -> s.TextDocumentCodeAction(p))
       "codeAction/resolve", requestHandling (fun s p -> s.CodeActionResolve(p))
       "textDocument/codeLens", requestHandling (fun s p -> s.TextDocumentCodeLens(p))
       "codeLens/resolve", requestHandling (fun s p -> s.CodeLensResolve(p))
-      "textDocument/references", requestHandling (fun s p -> s.TextDocumentReferences(p))
-      "textDocument/documentHighlight", requestHandling (fun s p -> s.TextDocumentDocumentHighlight(p))
-      "textDocument/documentLink", requestHandling (fun s p -> s.TextDocumentDocumentLink(p))
+      "textDocument/references", requestHandling (fun s p -> s.``textDocument/references`` (p))
+      "textDocument/documentHighlight", requestHandling (fun s p -> s.``textDocument/documentHighlight`` (p))
+      "textDocument/documentLink", requestHandling (fun s p -> s.``textDocument/documentLink`` (p))
       "textDocument/signatureHelp", requestHandling (fun s p -> s.TextDocumentSignatureHelp(p))
-      "documentLink/resolve", requestHandling (fun s p -> s.DocumentLinkResolve(p))
+      "documentLink/resolve", requestHandling (fun s p -> s.``documentLink/resolve`` (p))
       "textDocument/documentColor", requestHandling (fun s p -> s.TextDocumentDocumentColor(p))
       "textDocument/colorPresentation", requestHandling (fun s p -> s.TextDocumentColorPresentation(p))
       "textDocument/formatting", requestHandling (fun s p -> s.TextDocumentFormatting(p))