Merge pull request #143 from nojaf/fix-142

Check if DU type is not generic parameter in StructDiscriminatedUnionAnalyzer.

Author: nojaf

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.14.2 - 2025-03-18
+
+### Fixed
+
+* InvalidOperationException on generic discriminated unions. [#142](https://github.com/ionide/ionide-analyzers/issues/142)
 
 ## 0.14.1 - 2025-03-06
 

src/Ionide.Analyzers/Suggestion/StructDiscriminatedUnionAnalyzer.fs

@@ -110,7 +110,10 @@ let private analyze
 
                     if ff.FieldType.IsFunctionType || ff.FieldType.IsAnonRecordType then
                         false
-                    elif not (Seq.isEmpty ff.FieldType.GenericArguments) then
+                    elif
+                        ff.FieldType.IsGenericParameter
+                        || not (Seq.isEmpty ff.FieldType.GenericArguments)
+                    then
                         false
                     else
 

tests/Ionide.Analyzers.Tests/Suggestion/StructDiscriminatedUnionAnalyzerTests.fs

@@ -250,3 +250,19 @@ type TwoCaseDU = | Empty | Full of int[]
         let! msgs = structDiscriminatedUnionCliAnalyzer ctx
         Assert.That(msgs, Is.Empty)
     }
+
+[<Test>]
+let ``negative: generic types`` () =
+    async {
+        let source =
+            """module Foo
+
+type Validated<'valid, 'invalid> =
+    | Valid of 'valid
+    | Invalid of 'invalid
+    """
+
+        let ctx = getContext projectOptions source
+        let! msgs = structDiscriminatedUnionCliAnalyzer ctx
+        Assert.That(msgs, Is.Empty)
+    }