Merge pull request #22 from dawedawe/fix_analyzer_codes

dawedawe · web-flow · commit d34b97707d30 · 2023-11-09T08:53:32.000+01:00
add "IONIDE-" prefix to all analyzer codes
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Fixed
 * Fix analyzers urls. [#19](https://github.com/ionide/ionide-analyzers/pull/19)
+* Fix analyzers codes. [#22](https://github.com/ionide/ionide-analyzers/pull/22)
 
 ### Added
 * Support for referencing a local analyzers SDK. [#18](https://github.com/ionide/ionide-analyzers/pull/18)
diff --git a/src/Ionide.Analyzers/Suggestion/IgnoreFunctionAnalyzer.fs b/src/Ionide.Analyzers/Suggestion/IgnoreFunctionAnalyzer.fs
@@ -24,7 +24,7 @@ let ignoreFunctionAnalyzer (ctx: CliContext) =
                             {
                                 Type = "IgnoreFunctionAnalyzer"
                                 Message = "A function is being ignored. Did you mean to execute this?"
-                                Code = "003"
+                                Code = "IONIDE-003"
                                 Severity = Severity.Warning
                                 Range = m
                                 Fixes = []
diff --git a/src/Ionide.Analyzers/Suggestion/UnnamedDiscriminatedUnionFieldAnalyzer.fs b/src/Ionide.Analyzers/Suggestion/UnnamedDiscriminatedUnionFieldAnalyzer.fs
@@ -28,7 +28,7 @@ let unnamedDiscriminatedUnionFieldAnalyzer (ctx: CliContext) =
                                 {
                                     Type = "UnnamedDiscriminatedUnionFieldAnalyzer"
                                     Message = "Field inside union case is not named!"
-                                    Code = "004"
+                                    Code = "IONIDE-004"
                                     Severity = Severity.Hint
                                     Range = mField
                                     Fixes = []

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ let ignoreFunctionAnalyzer (ctx: CliContext) =`
`24`	`24`	`{`
`25`	`25`	`Type = "IgnoreFunctionAnalyzer"`
`26`	`26`	`Message = "A function is being ignored. Did you mean to execute this?"`
`27`		`- Code = "003"`
	`27`	`+ Code = "IONIDE-003"`
`28`	`28`	`Severity = Severity.Warning`
`29`	`29`	`Range = m`
`30`	`30`	`Fixes = []`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ let unnamedDiscriminatedUnionFieldAnalyzer (ctx: CliContext) =`
`28`	`28`	`{`
`29`	`29`	`Type = "UnnamedDiscriminatedUnionFieldAnalyzer"`
`30`	`30`	`Message = "Field inside union case is not named!"`
`31`		`- Code = "004"`
	`31`	`+ Code = "IONIDE-004"`
`32`	`32`	`Severity = Severity.Hint`
`33`	`33`	`Range = mField`
`34`	`34`	`Fixes = []`