don't repeat attribute args

Author: dawedawe

src/Ionide.Analyzers/Suggestion/CopyAndUpdateRecordChangesAllFieldsAnalyzer.fs

@@ -58,14 +58,20 @@ let analyze parseTree (typedTree: FSharpImplementationFileContents option) =
 
     Seq.toList messages
 
-[<CliAnalyzer("CopyAndUpdateRecordChangesAllFieldsAnalyzer",
-              "Detect if all fields in a record update expression are updated.",
-              "https://ionide.io/ionide-analyzers/suggestion/001.html")>]
+[<Literal>]
+let name = "CopyAndUpdateRecordChangesAllFieldsAnalyzer"
+
+[<Literal>]
+let shortDescription =
+    "Detect if all fields in a record update expression are updated."
+
+[<Literal>]
+let helpUri = "https://ionide.io/ionide-analyzers/suggestion/001.html"
+
+[<CliAnalyzer(name, shortDescription, helpUri)>]
 let copyAndUpdateRecordChangesAllFieldsCliAnalyzer: Analyzer<CliContext> =
     fun (context: CliContext) -> async { return analyze context.ParseFileResults.ParseTree context.TypedTree }
 
-[<EditorAnalyzer("CopyAndUpdateRecordChangesAllFieldsAnalyzer",
-                 "Detect if all fields in a record update expression are updated.",
-                 "https://ionide.io/ionide-analyzers/suggestion/001.html")>]
+[<EditorAnalyzer(name, shortDescription, helpUri)>]
 let copyAndUpdateRecordChangesAllFieldsEditorAnalyzer: Analyzer<EditorContext> =
     fun (context: EditorContext) -> async { return analyze context.ParseFileResults.ParseTree context.TypedTree }

src/Ionide.Analyzers/Suggestion/EmptyStringAnalyzer.fs

@@ -41,14 +41,19 @@ let analyze (typedTree: FSharpImplementationFileContents) =
     )
     |> Seq.toList
 
-[<EditorAnalyzer("EmptyStringAnalyzer",
-                 "Verifies testing for an empty string is done efficiently.",
-                 "https://ionide.io/ionide-analyzers/suggestion/005.html")>]
+[<Literal>]
+let name = "EmptyStringAnalyzer"
+
+[<Literal>]
+let shortDescription = "Verifies testing for an empty string is done efficiently."
+
+[<Literal>]
+let helpUri = "https://ionide.io/ionide-analyzers/suggestion/005.html"
+
+[<EditorAnalyzer(name, shortDescription, helpUri)>]
 let emptyStringEditorAnalyzer (ctx: EditorContext) =
     async { return ctx.TypedTree |> Option.map analyze |> Option.defaultValue [] }
 
-[<CliAnalyzer("EmptyStringAnalyzer",
-              "Verifies testing for an empty string is done efficiently.",
-              "https://ionide.io/ionide-analyzers/suggestion/005.html")>]
+[<CliAnalyzer(name, shortDescription, helpUri)>]
 let emptyStringCliAnalyzer (ctx: CliContext) =
     async { return ctx.TypedTree |> Option.map analyze |> Option.defaultValue [] }

src/Ionide.Analyzers/Suggestion/HandleOptionGracefullyAnalyzer.fs

@@ -45,12 +45,18 @@ let analyze (typedTree: FSharpImplementationFileContents option) =
         walkTast walker typedTree
         Seq.toList messages
 
-[<CliAnalyzer("HandleOptionGracefullyAnalyzer",
-              "Replace unsafe option unwrapping with graceful handling of each case.",
-              "https://ionide.io/ionide-analyzers/suggestion/006.html")>]
+[<Literal>]
+let name = "HandleOptionGracefullyAnalyzer"
+
+[<Literal>]
+let shortDescription =
+    "Replace unsafe option unwrapping with graceful handling of each case."
+
+[<Literal>]
+let helpUri = "https://ionide.io/ionide-analyzers/suggestion/006.html"
+
+[<CliAnalyzer(name, shortDescription, helpUri)>]
 let optionGetCliAnalyzer (ctx: CliContext) = async { return analyze ctx.TypedTree }
 
-[<EditorAnalyzer("HandleOptionGracefullyAnalyzer",
-                 "Replace unsafe option unwrapping with graceful handling of each case.",
-                 "https://ionide.io/ionide-analyzers/suggestion/006.html")>]
+[<EditorAnalyzer(name, shortDescription, helpUri)>]
 let optionGetEditorAnalyzer (ctx: EditorContext) = async { return analyze ctx.TypedTree }

src/Ionide.Analyzers/Suggestion/IgnoreFunctionAnalyzer.fs

@@ -33,12 +33,17 @@ let analyzer (typedTree: FSharpImplementationFileContents option) =
         walkTast tastCollector typedTree
         Seq.toList messages
 
-[<CliAnalyzer("IgnoreFunctionAnalyzer",
-              "A function is being ignored. Did you mean to execute this?",
-              "https://ionide.io/ionide-analyzers/suggestion/003.html")>]
+[<Literal>]
+let name = "IgnoreFunctionAnalyzer"
+
+[<Literal>]
+let shortDescription = "A function is being ignored. Did you mean to execute this?"
+
+[<Literal>]
+let helpUri = "https://ionide.io/ionide-analyzers/suggestion/003.html"
+
+[<CliAnalyzer(name, shortDescription, helpUri)>]
 let ignoreFunctionCliAnalyzer (ctx: CliContext) = async { return analyzer ctx.TypedTree }
 
-[<EditorAnalyzer("IgnoreFunctionAnalyzer",
-                 "A function is being ignored. Did you mean to execute this?",
-                 "https://ionide.io/ionide-analyzers/suggestion/003.html")>]
+[<EditorAnalyzer(name, shortDescription, helpUri)>]
 let ignoreFunctionEditorAnalyzer (ctx: EditorContext) = async { return analyzer ctx.TypedTree }

src/Ionide.Analyzers/Suggestion/UnnamedDiscriminatedUnionFieldAnalyzer.fs

@@ -37,14 +37,19 @@ let analyze parseTree =
 
     Seq.toList messages
 
-[<CliAnalyzer("UnnamedDiscriminatedUnionFieldAnalyzer",
-              "Verifies each field in a union case is named.",
-              "https://ionide.io/ionide-analyzers/suggestion/004.html")>]
+[<Literal>]
+let name = "UnnamedDiscriminatedUnionFieldAnalyzer"
+
+[<Literal>]
+let shortDescription = "Verifies each field in a union case is named."
+
+[<Literal>]
+let helpUri = "https://ionide.io/ionide-analyzers/suggestion/004.html"
+
+[<CliAnalyzer(name, shortDescription, helpUri)>]
 let unnamedDiscriminatedUnionFieldCliAnalyzer (ctx: CliContext) =
     async { return analyze ctx.ParseFileResults.ParseTree }
 
-[<EditorAnalyzer("UnnamedDiscriminatedUnionFieldAnalyzer",
-                 "Verifies each field in a union case is named.",
-                 "https://ionide.io/ionide-analyzers/suggestion/004.html")>]
+[<EditorAnalyzer(name, shortDescription, helpUri)>]
 let unnamedDiscriminatedUnionFieldEditorAnalyzer (ctx: EditorContext) =
     async { return analyze ctx.ParseFileResults.ParseTree }