Skip to content

Commit aa2565a

Browse files
committed
Fix #209: Remove (* *) from brackets config
language-configuration.json lets you define various pairs of brackets and braces for autoclosing, surrounding selected text with characters, and, as it turns out, dictating which brackets get colorized by the native bracket colorizer. As far as I can tell, putting the block comment brackets inside the `brackets` field is pointless. We color our comments green anyway, so the colors don't show anyway. It is true that F# provides support for nested comment blocks, but we aren't taking advantage of the color feature anyway (and I'm unsure if it's even possible to do so). The block comments should, however, remain in the other fields that control autocomplete and surrounding selected text.
1 parent 7d029a4 commit aa2565a

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

fsharp.syntaxtest/language-configuration.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636

3737
"brackets": [
3838
["(", ")"],
39-
["(*", "*)"],
4039
["{", "}"],
4140
["[", "]"],
4241
["[|", "|]"],

sample-code/SimpleTypes.fs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ module Test =
4444
let b = ""
4545

4646
let double = (*) 2 // *) was being captured as a comment
47+
48+
// Both of these operators should have the same syntax highlighting,
49+
// specifically the infix multiplication operator.
50+
let foldSum xs = Seq.fold (+) 0 xs
51+
let foldProduct xs = Seq.fold (*) xs
4752

4853
(**
4954
This block is colorized because markdown can set up his context.
@@ -62,7 +67,6 @@ file as markdown
6267
*)
6368
let d = ""
6469

65-
6670
(* Unbalanced comment, which turn everything after itself into comment **)
6771
let e = (* comment// *) "not a comment"
6872

0 commit comments

Comments
 (0)