Skip to content

Commit 6f10c22

Browse files
committed
Fix bug where tests with the same name could conflict between projects
IcedTasks experienced this issue when all tests were run. Merging tests results used to be per-project, but now is not. So the test result venn requires project scope data
1 parent a4c788c commit 6f10c22

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/Components/TestExplorer.fs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1550,8 +1550,10 @@ module Interactions =
15501550
testResult.TargetFramework
15511551
testResult.FullTestName
15521552

1553-
let treeItemComparable (t: TestItem) = TestItem.getFullName t.id
1554-
let resultComparable (r: TestResult) = r.FullTestName
1553+
let treeItemComparable (t: TestItem) = TestItem.getId t
1554+
1555+
let resultComparable (r: TestResult) =
1556+
TestItem.constructId r.ProjectFilePath r.FullTestName
15551557

15561558
let missing, expected, added =
15571559
ArrayExt.venn treeItemComparable resultComparable expectedToRun testResults

0 commit comments

Comments
 (0)