Skip to content

Commit af58c42

Browse files
committed
deprecate options for source text and adaptive mode, and remove their associated CLI argument settings
1 parent 7723dcf commit af58c42

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

RELEASE_NOTES.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
### 7.15.0 - 15.10.2023
2+
* Update to FSAC 0.66.1. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.66.1) for more details.
3+
* Updated the F# syntax grammar to pick up fixes for backticked namespace and module names, let struct syntax highlights, and customer operators/doc comments. (Thanks @dawedawe and @MangelMaxime!)
4+
* Added a deprecation message to `FSharp.inlayHints.enabled` in favor of `editor.inlayHints.enabled`.
15

26
### 7.14.0 - 09.10.2023
3-
* Update to FSAC 0.65.0. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.64.0) for more details.
7+
* Update to FSAC 0.65.0. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.65.0) for more details.
48
* [Don't offer to reference the target project when adding a project reference](https://github.com/ionide/ionide-vscode-fsharp/pull/1945) (Thanks @dawedawe!)
59

610
### 7.13.0 - 05.10.2023

paket.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,4 +241,4 @@ STORAGE: PACKAGES
241241
RESTRICTION: == netstandard2.0
242242
NUGET
243243
remote: https://api.nuget.org/v3/index.json
244-
fsautocomplete (0.66)
244+
fsautocomplete (0.66.1)

release/CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
### 7.15.0 - 15.10.2023
2+
* Update to FSAC 0.66.1. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.66.1) for more details.
3+
* Updated the F# syntax grammar to pick up fixes for backticked namespace and module names, let struct syntax highlights, and customer operators/doc comments. (Thanks @dawedawe and @MangelMaxime!)
4+
* Added a deprecation message to `FSharp.inlayHints.enabled` in favor of `editor.inlayHints.enabled`.
15

26
### 7.14.0 - 09.10.2023
3-
* Update to FSAC 0.65.0. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.64.0) for more details.
7+
* Update to FSAC 0.65.0. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.65.0) for more details.
48
* [Don't offer to reference the target project when adding a project reference](https://github.com/ionide/ionide-vscode-fsharp/pull/1945) (Thanks @dawedawe!)
59

610
### 7.13.0 - 05.10.2023

release/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,6 +479,7 @@
479479
"FSharp.enableAdaptiveLspServer": {
480480
"default": true,
481481
"description": "Enables Enable LSP Server based on FSharp.Data.Adaptive. This can improve stability. Requires restart.",
482+
"markdownDeprecationMessage": "This setting has been deprecated because it is now the only behavior of the LSP Server.",
482483
"type": "boolean"
483484
},
484485
"FSharp.enableAnalyzers": {
@@ -584,6 +585,7 @@
584585
"FSharp.fsac.sourceTextImplementation": {
585586
"default": "RoslynSourceText",
586587
"description": "Enables the use of a new source text implementation. This may have better memory characteristics. Requires restart.",
588+
"markdownDeprecationMessage": "This setting is deprecated because the RoslynSourceText SourceText implementation has been adopted as the only implementation in the LSP Server.",
587589
"enum": [
588590
"NamedText",
589591
"RoslynSourceText"
@@ -657,7 +659,7 @@
657659
},
658660
"FSharp.inlayHints.enabled": {
659661
"default": true,
660-
"markdownDeprecationMessage": "This can be controlled by `editor.inlayHints.enabled` instead.",
662+
"markdownDeprecationMessage": "This can be controlled by \u0060editor.inlayHints.enabled\u0060 instead.",
661663
"description": "Controls if the inlay hints feature is enabled",
662664
"type": "boolean"
663665
},

src/Core/LanguageService.fs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -670,9 +670,6 @@ Consider:
670670

671671
let getOptions (c: ExtensionContext) : JS.Promise<Executable> =
672672
promise {
673-
let enableAdaptiveLspServer =
674-
"FSharp.enableAdaptiveLspServer" |> Configuration.get true
675-
676673
let openTelemetryEnabled = "FSharp.openTelemetry.enabled" |> Configuration.get false
677674

678675
let enableProjectGraph =
@@ -722,9 +719,6 @@ Consider:
722719

723720
let verbose = "FSharp.verboseLogging" |> Configuration.get false
724721

725-
let sourceText =
726-
"FSharp.fsac.sourceTextImplementation" |> Configuration.get "RoslynSourceText"
727-
728722
/// given a set of tfms and a target tfm, find the first of the set that satisfies the target.
729723
/// if no target is found, use the 'latest' tfm
730724
/// e.g. [net6.0, net7.0] + net8.0 -> net7.0
@@ -914,16 +908,13 @@ Consider:
914908
yield "--wait-for-debugger"
915909
if enableProjectGraph then
916910
yield "--project-graph-enabled"
917-
if enableAdaptiveLspServer then
918-
yield "--adaptive-lsp-server-enabled"
919911
if openTelemetryEnabled then
920912
yield "--otel-exporter-enabled"
921913
if verbose then
922914
yield "--verbose"
923915
if fsacSilencedLogs <> null && fsacSilencedLogs.Length > 0 then
924916
yield "--filter"
925917
yield! fsacSilencedLogs
926-
yield $"--source-text-factory={sourceText}"
927918
match c.storageUri with
928919
| Some uri ->
929920
let storageDir = uri.fsPath

0 commit comments

Comments
 (0)