Skip to content

Commit cd1dff8

Browse files
committed
Reviewer feedback
1 parent 1df0537 commit cd1dff8

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

src/Components/TestExplorer.fs

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -313,12 +313,15 @@ module TrxParser =
313313
{ Message: string option
314314
StackTrace: string option }
315315

316+
type Output =
317+
{ StdOut: string option
318+
ErrorInfo: ErrorInfo }
319+
316320
type UnitTestResult =
317321
{ ExecutionId: string
318322
Outcome: string
319323
Duration: TimeSpan
320-
Output: string option
321-
ErrorInfo: ErrorInfo }
324+
Output: Output }
322325

323326
type TestWithResult =
324327
{ UnitTest: UnitTest
@@ -392,10 +395,11 @@ module TrxParser =
392395
{ ExecutionId = executionId
393396
Outcome = outcome
394397
Duration = durationSpan
395-
Output = outputMessage
396-
ErrorInfo =
397-
{ StackTrace = errorStackTrace
398-
Message = errorInfoMessage } }
398+
Output =
399+
{ StdOut = outputMessage
400+
ErrorInfo =
401+
{ StackTrace = errorStackTrace
402+
Message = errorInfoMessage } } }
399403

400404
xpathSelector.SelectNodes "/t:TestRun/t:Results/t:UnitTestResult"
401405
|> Array.map extractRow
@@ -1310,7 +1314,7 @@ module Interactions =
13101314

13111315
let private trxResultToTestResult (trxResult: TrxParser.TestWithResult) =
13121316
let expected, actual =
1313-
match trxResult.UnitTestResult.ErrorInfo.Message with
1317+
match trxResult.UnitTestResult.Output.ErrorInfo.Message with
13141318
| None -> None, None
13151319
| Some message ->
13161320
let lines =
@@ -1325,9 +1329,9 @@ module Interactions =
13251329

13261330
{ FullTestName = trxResult.UnitTest.FullName
13271331
Outcome = !!trxResult.UnitTestResult.Outcome
1328-
Output = trxResult.UnitTestResult.Output
1329-
ErrorMessage = trxResult.UnitTestResult.ErrorInfo.Message
1330-
ErrorStackTrace = trxResult.UnitTestResult.ErrorInfo.StackTrace
1332+
Output = trxResult.UnitTestResult.Output.StdOut
1333+
ErrorMessage = trxResult.UnitTestResult.Output.ErrorInfo.Message
1334+
ErrorStackTrace = trxResult.UnitTestResult.Output.ErrorInfo.StackTrace
13311335
Expected = expected
13321336
Actual = actual
13331337
Timing = trxResult.UnitTestResult.Duration.Milliseconds

0 commit comments

Comments
 (0)