Skip to content

Commit 4a4a64a

Browse files
authored
chore(deps): bump webrtc (#150)
1 parent 5321407 commit 4a4a64a

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ require (
1010
github.com/pion/rtp v1.6.0
1111
github.com/pion/sdp/v2 v2.4.0
1212
github.com/pion/transport v0.10.1
13-
github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911055832-fc11e7c66cff
13+
github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911180519-81cfadaf06cb
1414
github.com/rs/zerolog v1.19.0
1515
github.com/sourcegraph/jsonrpc2 v0.0.0-20200429184054-15c2290dcb37
1616
github.com/spf13/viper v1.7.1

go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,8 @@ github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200910131025-c2ed6ee8350d h1:bLRBuJW
277277
github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200910131025-c2ed6ee8350d/go.mod h1:stOX+uPii8HN/Qqc/fXpbCyXp2fgKa/bMR6BHO3rF4I=
278278
github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911055832-fc11e7c66cff h1:htjaEjrEL8udfZuEUjAu/XRj+KJfhfdQji73GN+ml6U=
279279
github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911055832-fc11e7c66cff/go.mod h1:stOX+uPii8HN/Qqc/fXpbCyXp2fgKa/bMR6BHO3rF4I=
280+
github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911180519-81cfadaf06cb h1:9ZudR3bNMttmxXB70EIY3+lxuTPoBrvVgVHZvc4AHfw=
281+
github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911180519-81cfadaf06cb/go.mod h1:stOX+uPii8HN/Qqc/fXpbCyXp2fgKa/bMR6BHO3rF4I=
280282
github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
281283
github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
282284
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=

pkg/webrtctransport.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -244,12 +244,13 @@ func (p *WebRTCTransport) NewSender(intrack *webrtc.Track) (Sender, error) {
244244
// Create webrtc sender for the peer we are sending track to
245245
sender := NewWebRTCSender(p.ctx, outtrack, s)
246246

247-
sender.OnClose(func() {
248-
err = p.pc.RemoveTrack(s)
249-
if err != nil {
250-
log.Errorf("Error closing sender: %s", err)
251-
}
252-
})
247+
// TODO: remove once resolved https://github.com/pion/webrtc/issues/1343
248+
// sender.OnClose(func() {
249+
// err = p.pc.RemoveTrack(s)
250+
// if err != nil {
251+
// log.Errorf("Error closing sender: %s", err)
252+
// }
253+
// })
253254

254255
return sender, nil
255256
}

0 commit comments

Comments
 (0)